From patchwork Sat Jun 30 02:02:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amos Kong X-Patchwork-Id: 168284 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B8B60B6F59 for ; Sat, 30 Jun 2012 12:02:40 +1000 (EST) Received: from localhost ([::1]:34457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skn1C-00067x-01 for incoming@patchwork.ozlabs.org; Fri, 29 Jun 2012 22:02:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skn14-00067e-SA for qemu-devel@nongnu.org; Fri, 29 Jun 2012 22:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Skn13-0004Z3-4V for qemu-devel@nongnu.org; Fri, 29 Jun 2012 22:02:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skn12-0004Yz-Sr for qemu-devel@nongnu.org; Fri, 29 Jun 2012 22:02:29 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5U22Q1J024839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Jun 2012 22:02:27 -0400 Received: from t400.nay.redhat.com (vpn1-115-45.nay.redhat.com [10.66.115.45]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5U22Nhm026370; Fri, 29 Jun 2012 22:02:24 -0400 From: akong@redhat.com To: pkrempa@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org Date: Sat, 30 Jun 2012 10:02:20 +0800 Message-Id: <1341021740-11426-1-git-send-email-akong@redhat.com> In-Reply-To: <1341021237-11293-1-git-send-email-akong@redhat.com> References: <1341021237-11293-1-git-send-email-akong@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Amos Kong Subject: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Amos Kong Currently qemu outputs some low-level error in qemu-sockets.c when failed to start vnc server. eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known' Some libvirt users could not know what's happened with this unclear error message. This patch added a more descriptive error message. Signed-off-by: Amos Kong --- V2: improve the commitlog --- vl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 1329c30..82607a7 100644 --- a/vl.c +++ b/vl.c @@ -3585,8 +3585,11 @@ int main(int argc, char **argv, char **envp) /* init remote displays */ if (vnc_display) { vnc_display_init(ds); - if (vnc_display_open(ds, vnc_display) < 0) + if (vnc_display_open(ds, vnc_display) < 0) { + fprintf(stderr, "Failed to start VNC server on `%s'\n", + vnc_display); exit(1); + } if (show_vnc_port) { printf("VNC server running on `%s'\n", vnc_display_local_addr(ds));