From patchwork Sat Jun 30 01:07:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 168281 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6FF0FB6F77 for ; Sat, 30 Jun 2012 11:18:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754115Ab2F3BSF (ORCPT ); Fri, 29 Jun 2012 21:18:05 -0400 Received: from seven.medozas.de ([5.9.24.206]:57308 "EHLO seven.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778Ab2F3BSE (ORCPT ); Fri, 29 Jun 2012 21:18:04 -0400 X-Greylist: delayed 605 seconds by postgrey-1.27 at vger.kernel.org; Fri, 29 Jun 2012 21:18:04 EDT Received: by seven.medozas.de (Postfix, from userid 25121) id 7256E96A00DC; Sat, 30 Jun 2012 03:07:55 +0200 (CEST) From: Jan Engelhardt To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org Subject: [PATCH] build: remove stray empty variable Date: Sat, 30 Jun 2012 03:07:54 +0200 Message-Id: <1341018474-1274-2-git-send-email-jengelh@inai.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1341018474-1274-1-git-send-email-jengelh@inai.de> References: <1341018474-1274-1-git-send-email-jengelh@inai.de> Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Compilation can fail when libnfnetlink is not in a directory searched by default. Reason is the empty KERNELDIR variable which makes for a gcc command like: gcc -I. -I../include -I -Wall -I/usr/include/libnfnetlink-1.0.0+git28 -Wall -c libnetfilter_queue.c What one would expect is that gcc would search in the (non-existent) directory "-Wall" and just continue as usual, since -Wall is specified again. Instead, gcc versions before 4.6 attempt to search the (similarly non-existent) directory "-I/usr/[...]" and thus miss. Signed-off-by: Jan Engelhardt --- Make_global.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Make_global.am b/Make_global.am index c16cb09..a4e9bd9 100644 --- a/Make_global.am +++ b/Make_global.am @@ -1,2 +1,2 @@ -AM_CPPFLAGS = -I${top_srcdir}/include -I${KERNELDIR} ${LIBNFNETLINK_CFLAGS} +AM_CPPFLAGS = -I${top_srcdir}/include ${LIBNFNETLINK_CFLAGS} AM_CFLAGS = -Wall