Patchwork build: remove stray empty variable

login
register
mail settings
Submitter Jan Engelhardt
Date June 30, 2012, 1:07 a.m.
Message ID <1341018474-1274-2-git-send-email-jengelh@inai.de>
Download mbox | patch
Permalink /patch/168281/
State Accepted
Headers show

Comments

Jan Engelhardt - June 30, 2012, 1:07 a.m.
Compilation can fail when libnfnetlink is not in a directory searched
by default. Reason is the empty KERNELDIR variable which makes for a
gcc command like:

	gcc -I. -I../include -I -Wall -I/usr/include/libnfnetlink-1.0.0+git28
	-Wall -c libnetfilter_queue.c

What one would expect is that gcc would search in the (non-existent)
directory "-Wall" and just continue as usual, since -Wall is specified
again. Instead, gcc versions before 4.6 attempt to search the
(similarly non-existent) directory "-I/usr/[...]" and thus miss.

Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
 Make_global.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/Make_global.am b/Make_global.am
index c16cb09..a4e9bd9 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -1,2 +1,2 @@ 
-AM_CPPFLAGS = -I${top_srcdir}/include -I${KERNELDIR} ${LIBNFNETLINK_CFLAGS}
+AM_CPPFLAGS = -I${top_srcdir}/include ${LIBNFNETLINK_CFLAGS}
 AM_CFLAGS = -Wall