Patchwork [03/12] savevm: remove SaveSetParamsHandler

login
register
mail settings
Submitter Juan Quintela
Date June 28, 2012, 7:22 p.m.
Message ID <704b60a0d2b32fbf6bf229b115082c2b929a4731.1340910651.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/167940/
State New
Headers show

Comments

Juan Quintela - June 28, 2012, 7:22 p.m.
It was used only once, just unfold.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 vmstate.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Orit Wasserman - July 1, 2012, 9:40 a.m.
On 06/28/2012 10:22 PM, Juan Quintela wrote:
> It was used only once, just unfold.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  vmstate.h |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/vmstate.h b/vmstate.h
> index 4bce53b..5e1a7cc 100644
> --- a/vmstate.h
> +++ b/vmstate.h
> @@ -26,13 +26,12 @@
>  #ifndef QEMU_VMSTATE_H
>  #define QEMU_VMSTATE_H 1
> 
> -typedef void SaveSetParamsHandler(const MigrationParams *params, void * opaque);
>  typedef void SaveStateHandler(QEMUFile *f, void *opaque);
>  typedef int SaveLiveStateHandler(QEMUFile *f, int stage, void *opaque);
>  typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
> 
>  typedef struct SaveVMHandlers {
> -    SaveSetParamsHandler *set_params;
> +    void (*set_params)(const MigrationParams *params, void * opaque);
>      SaveStateHandler *save_state;
>      SaveLiveStateHandler *save_live_state;
>      LoadStateHandler *load_state;
>

Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Patch

diff --git a/vmstate.h b/vmstate.h
index 4bce53b..5e1a7cc 100644
--- a/vmstate.h
+++ b/vmstate.h
@@ -26,13 +26,12 @@ 
 #ifndef QEMU_VMSTATE_H
 #define QEMU_VMSTATE_H 1

-typedef void SaveSetParamsHandler(const MigrationParams *params, void * opaque);
 typedef void SaveStateHandler(QEMUFile *f, void *opaque);
 typedef int SaveLiveStateHandler(QEMUFile *f, int stage, void *opaque);
 typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);

 typedef struct SaveVMHandlers {
-    SaveSetParamsHandler *set_params;
+    void (*set_params)(const MigrationParams *params, void * opaque);
     SaveStateHandler *save_state;
     SaveLiveStateHandler *save_live_state;
     LoadStateHandler *load_state;