From patchwork Thu Jun 28 16:17:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT From: Kevin Hilman X-Patchwork-Id: 167920 Message-Id: <1340900265-11962-1-git-send-email-khilman@ti.com> To: rtc-linux@googlegroups.com, linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Alessandro Zummo (maintainer:REAL TIME CLOCK (...), linux-kernel@vger.kernel.org (open list) Date: Thu, 28 Jun 2012 09:17:45 -0700 Requesting a threaded interrupt without a primary handler and without IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject bogus threaded irq requests), these requests are rejected. This causes ->probe() to fail, and the RTC driver not to be availble. To fix, add IRQF_ONESHOT to the IRQ flags. Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to wake from system suspend multiple times. Signed-off-by: Kevin Hilman --- This fix is needed in v3.5. Applies on top of v3.5-rc4. drivers/rtc/rtc-twl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 258abea..c5d06fe 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c @@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev) } ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt, - IRQF_TRIGGER_RISING, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, dev_name(&rtc->dev), rtc); if (ret < 0) { dev_err(&pdev->dev, "IRQ is not free.\n");