Patchwork [U-Boot] i2c: deblock i2c bus also if accessed before realocation

login
register
mail settings
Submitter Holger Brunck
Date June 28, 2012, 2:30 p.m.
Message ID <1340893822-4672-1-git-send-email-holger.brunck@keymile.com>
Download mbox | patch
Permalink /patch/167887/
State Accepted
Commit 8ec038a6a590c8ac66137502766ba10334c531e9
Delegated to: Heiko Schocher
Headers show

Comments

Holger Brunck - June 28, 2012, 2:30 p.m.
If we switch to a different i2c bus in changing the mux config for the
i2c mux, we have to be sure to deblock the bus also before realocation.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Heiko Schocher <hs@denx.de>
cc: Valentin Longchamp <valentin.longchamp@keymile.com>

---
 common/cmd_i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Holger Brunck - July 10, 2012, 9:25 a.m.
Hi Heiko,

On 06/28/2012 04:30 PM, Holger Brunck wrote:
> If we switch to a different i2c bus in changing the mux config for the
> i2c mux, we have to be sure to deblock the bus also before realocation.
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> cc: Heiko Schocher <hs@denx.de>
> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> 
> ---
>  common/cmd_i2c.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index 2cdc4ed..795814d 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -1445,6 +1445,7 @@ int i2c_mux_ident_muxstring_f (uchar *buf)
>  		oldpos = pos;
>  
>  	}
> +	i2c_init_board();
>  
>  	return 0;
>  }


do you consider this one as a bugfix for 2012.07 or do you think it should be
included in the next merge window?

Regards
Holger
Heiko Schocher - July 10, 2012, 9:36 a.m.
Hello Holger,

On 10.07.2012 11:25, Holger Brunck wrote:
> Hi Heiko,
>
> On 06/28/2012 04:30 PM, Holger Brunck wrote:
>> If we switch to a different i2c bus in changing the mux config for the
>> i2c mux, we have to be sure to deblock the bus also before realocation.
>>
>> Signed-off-by: Holger Brunck<holger.brunck@keymile.com>
>> cc: Heiko Schocher<hs@denx.de>
>> cc: Valentin Longchamp<valentin.longchamp@keymile.com>
>>
>> ---
>>   common/cmd_i2c.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
>> index 2cdc4ed..795814d 100644
>> --- a/common/cmd_i2c.c
>> +++ b/common/cmd_i2c.c
>> @@ -1445,6 +1445,7 @@ int i2c_mux_ident_muxstring_f (uchar *buf)
>>   		oldpos = pos;
>>
>>   	}
>> +	i2c_init_board();
>>
>>   	return 0;
>>   }
>
>
> do you consider this one as a bugfix for 2012.07 or do you think it should be
> included in the next merge window?

I queued it for the next merge window ...

bye,
Heiko

Patch

diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
index 2cdc4ed..795814d 100644
--- a/common/cmd_i2c.c
+++ b/common/cmd_i2c.c
@@ -1445,6 +1445,7 @@  int i2c_mux_ident_muxstring_f (uchar *buf)
 		oldpos = pos;
 
 	}
+	i2c_init_board();
 
 	return 0;
 }