Patchwork [U-Boot,1/2] at91sam9263ek: enable useful commands

login
register
mail settings
Submitter Andreas Bießmann
Date June 28, 2012, 12:32 p.m.
Message ID <1340886752-31199-1-git-send-email-andreas.devel@googlemail.com>
Download mbox | patch
Permalink /patch/167863/
State RFC
Delegated to: Andreas Bießmann
Headers show

Comments

Andreas Bießmann - June 28, 2012, 12:32 p.m.
Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
cc: Stelian Pop <stelian@popies.net>
---
 include/configs/at91sam9263ek.h |    2 --
 1 file changed, 2 deletions(-)
Andreas Bießmann - July 9, 2012, 11:23 a.m.
On 28.06.2012 14:32, Andreas Bießmann wrote:
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> cc: Stelian Pop <stelian@popies.net>
> ---
>  include/configs/at91sam9263ek.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/configs/at91sam9263ek.h b/include/configs/at91sam9263ek.h
> index f2163f1..2d46502 100644
> --- a/include/configs/at91sam9263ek.h
> +++ b/include/configs/at91sam9263ek.h
> @@ -108,10 +108,8 @@
>   * Command line configuration.
>   */
>  #include <config_cmd_default.h>
> -#undef CONFIG_CMD_BDI
>  #undef CONFIG_CMD_FPGA
>  #undef CONFIG_CMD_IMI
> -#undef CONFIG_CMD_IMLS

NAK, enabling imls  breaks all the configurations where NOR is not enabled:

---8<---
Configuring for at91sam9263ek_nandflash - Board: at91sam9263ek, Options:
AT91SAM9263,SYS_USE_NANDFLASH
/home/abiessmann/source/git_projects/u-boot-atmel/include/mtd/cfi_flash.h:174:22:
error: unknown type name 'flash_info_t'
/home/abiessmann/source/git_projects/u-boot-atmel/include/mtd/cfi_flash.h:174:43:
error: unknown type name 'flash_sect_t'
cmd_bootm.c:82:1: error: unknown type name 'flash_info_t'
cmd_bootm.c:1164:2: error: unknown type name 'flash_info_t'
cmd_bootm.c:1169:7: error: 'CONFIG_SYS_MAX_FLASH_BANKS' undeclared
(first use in this function)
cmd_bootm.c:1171:11: error: request for member 'flash_id' in something
not a structure or union
cmd_bootm.c:1171:25: error: 'FLASH_UNKNOWN' undeclared (first use in
this function)
cmd_bootm.c:1173:23: error: request for member 'sector_count' in
something not a structure or union
cmd_bootm.c:1175:22: error: request for member 'start' in something not
a structure or union
--->8---

Patch

diff --git a/include/configs/at91sam9263ek.h b/include/configs/at91sam9263ek.h
index f2163f1..2d46502 100644
--- a/include/configs/at91sam9263ek.h
+++ b/include/configs/at91sam9263ek.h
@@ -108,10 +108,8 @@ 
  * Command line configuration.
  */
 #include <config_cmd_default.h>
-#undef CONFIG_CMD_BDI
 #undef CONFIG_CMD_FPGA
 #undef CONFIG_CMD_IMI
-#undef CONFIG_CMD_IMLS
 #undef CONFIG_CMD_LOADS
 #undef CONFIG_CMD_SOURCE