From patchwork Thu Jun 28 10:44:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 167852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id E67DEB7005 for ; Thu, 28 Jun 2012 20:44:24 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SkCD1-0001vj-OK for incoming@patchwork.ozlabs.org; Thu, 28 Jun 2012 10:44:23 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SkCD0-0001ui-VJ for fwts-devel@lists.ubuntu.com; Thu, 28 Jun 2012 10:44:23 +0000 Received: from cpc19-craw6-2-0-cust5.croy.cable.virginmedia.com ([77.102.228.6] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SkCD0-0005Le-SW for fwts-devel@lists.ubuntu.com; Thu, 28 Jun 2012 10:44:22 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: s3: suspend/resume failures should be HIGH failures Date: Thu, 28 Jun 2012 11:44:21 +0100 Message-Id: <1340880262-13359-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/s3/s3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c index a666033..76bec19 100644 --- a/src/acpi/s3/s3.c +++ b/src/acpi/s3/s3.c @@ -165,19 +165,19 @@ static int s3_do_suspend_resume(fwts_framework *fw, /* Add in error check for pm-suspend status */ if ((status > 0) && (status < 128)) { (*pm_errors)++; - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedPreS3", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedPreS3", "pm-action failed before trying to put the system " "in the requested power saving state."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); } else if (status == 128) { (*pm_errors)++; - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionPowerStateS3", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionPowerStateS3", "pm-action tried to put the machine in the requested " "power state but failed."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); } else if (status > 128) { (*pm_errors)++; - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedS3", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedS3", "pm-action encountered an error and also failed to " "enter the requested power saving state."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT);