From patchwork Thu Jun 28 10:44:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 167851 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 54903B7005 for ; Thu, 28 Jun 2012 20:44:07 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SkCCk-0001oc-FG for incoming@patchwork.ozlabs.org; Thu, 28 Jun 2012 10:44:06 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SkCCj-0001oW-2A for fwts-devel@lists.ubuntu.com; Thu, 28 Jun 2012 10:44:05 +0000 Received: from cpc19-craw6-2-0-cust5.croy.cable.virginmedia.com ([77.102.228.6] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SkCCi-0005KV-VH for fwts-devel@lists.ubuntu.com; Thu, 28 Jun 2012 10:44:05 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: s4: hibernate/resume failures should be HIGH failures Date: Thu, 28 Jun 2012 11:44:04 +0100 Message-Id: <1340880244-13312-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/s4/s4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/acpi/s4/s4.c b/src/acpi/s4/s4.c index 368fdcc..087b881 100644 --- a/src/acpi/s4/s4.c +++ b/src/acpi/s4/s4.c @@ -177,19 +177,19 @@ static int s4_hibernate(fwts_framework *fw, /* Add in error check for pm-hibernate status */ if ((status > 0) && (status < 128)) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedPreS4", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedPreS4", "pm-action failed before trying to put the system " "in the requested power saving state."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); (*pm_errors)++; } else if (status == 128) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionPowerStateS4", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionPowerStateS4", "pm-action tried to put the machine in the requested " "power state but failed."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); (*pm_errors)++; } else if (status > 128) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, "PMActionFailedS4", + fwts_failed(fw, LOG_LEVEL_HIGH, "PMActionFailedS4", "pm-action encountered an error and also failed to " "enter the requested power saving state."); fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); @@ -278,7 +278,7 @@ static int s4_test_multiple(fwts_framework *fw) if ((!retried) && (tracing_buffer_size > 4096)) { retried = true; - fwts_failed(fw, LOG_LEVEL_MEDIUM, + fwts_failed(fw, LOG_LEVEL_HIGH, "TracingBufferTooBig", "/sys/kernel/debug/tracing/buffer_size_kb is set to %d Kbytes which " "may cause hibernate to fail. Programs such as ureadahead may have "