From patchwork Thu Jun 28 09:05:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 167819 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3C16FB6FFD for ; Thu, 28 Jun 2012 19:06:00 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341479160; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:Cc:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=uS5DeGVeradStTX+TK2vHUWGGS8=; b=fBUxgXlzS51sw9mtUodWFdVPYZlxs6N/lS2fyY5wZ/EophMmCJCkId5DGYWoqH TWvfzN9kTkPjJbvK+mSMAAZ/EK5IYZa4J0YXTVOjkbfJBNqmPKPXBtouhMsVdcQg kSNpgIRXUaQP5RaRsHLk6eSgmzax8Wd3LFhloWBBV51XE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Cc:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Mi1RMgCJwAFaxkg7vHEIjDhU3/5IQW709Luo7z4oUE5RiKCHqqSaSZ+NfNfQ4v JuirKxlVz80groV3gCe5+YAT4uhkytCOnT4iAdrpx05g5CCjoX7oTP5sNoFAy3OT LkS2azNl++GaCCD9NtBRCYbxfAmwtcISn2Mca6PLTAaLA=; Received: (qmail 27852 invoked by alias); 28 Jun 2012 09:05:51 -0000 Received: (qmail 27812 invoked by uid 22791); 28 Jun 2012 09:05:49 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, UPPERCASE_50_75, URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from eu1sys200aog108.obsmtp.com (HELO eu1sys200aog108.obsmtp.com) (207.126.144.125) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jun 2012 09:05:36 +0000 Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob108.postini.com ([207.126.147.11]) with SMTP ID DSNKT+weU32bgHRZIRNm+TY1e4Iwmlx8N/Bf@postini.com; Thu, 28 Jun 2012 09:05:35 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6E698124; Thu, 28 Jun 2012 09:05:21 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A808D28BB; Thu, 28 Jun 2012 09:05:21 +0000 (GMT) Received: from [164.129.122.162] (164.129.122.162) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.192.1; Thu, 28 Jun 2012 11:05:21 +0200 Message-ID: <4FEC1E4F.9020404@st.com> Date: Thu, 28 Jun 2012 11:05:19 +0200 From: Christophe Lyon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Alexandre Oliva Cc: "gcc-patches@gcc.gnu.org" , "bonzini@gnu.org" , "dj@redhat.com" , "neroden@gcc.gnu.org" , "Ralf.Wildenhues@gmx.de" Subject: Re: [PATCH][configure] Make sure CFLAGS_FOR_TARGET And CXXFLAGS_FOR_TARGET contain -O2 References: <4F744C01.8030909@st.com> <4F8C15DC.3020503@st.com> <4FE8818D.6020808@st.com> <4FE976CF.1010000@st.com> <4FEACD80.1000305@st.com> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 28.06.2012 09:32, Alexandre Oliva wrote: > I suggest changing both occurrences of $CFLAGS within the case > statements, then; the more uniform logic is more appealing to me. > > Patch approved with these changes. > > Thanks, > Thanks; here is an updated version taking your comment into account. Can you commit it for me (I don't have write access). Thanks. Christophe. 2012-06-28 Christophe Lyon * configure.ac (CFLAGS_FOR_TARGET, CXXFLAGS_FOR_TARGET): Make sure they contain -O2. * configure: Regenerate. diff --git a/configure b/configure index 083f2ce..1ab12db 100755 --- a/configure +++ b/configure @@ -6690,11 +6690,11 @@ if test "x$CFLAGS_FOR_TARGET" = x; then CFLAGS_FOR_TARGET=$CFLAGS case " $CFLAGS " in *" -O2 "*) ;; - *) CFLAGS_FOR_TARGET="-O2 $CFLAGS" ;; + *) CFLAGS_FOR_TARGET="-O2 $CFLAGS_FOR_TARGET" ;; esac case " $CFLAGS " in *" -g "* | *" -g3 "*) ;; - *) CFLAGS_FOR_TARGET="-g $CFLAGS" ;; + *) CFLAGS_FOR_TARGET="-g $CFLAGS_FOR_TARGET" ;; esac fi @@ -6703,11 +6703,11 @@ if test "x$CXXFLAGS_FOR_TARGET" = x; then CXXFLAGS_FOR_TARGET=$CXXFLAGS case " $CXXFLAGS " in *" -O2 "*) ;; - *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS" ;; + *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS_FOR_TARGET" ;; esac case " $CXXFLAGS " in *" -g "* | *" -g3 "*) ;; - *) CXXFLAGS_FOR_TARGET="-g $CXXFLAGS" ;; + *) CXXFLAGS_FOR_TARGET="-g $CXXFLAGS_FOR_TARGET" ;; esac fi diff --git a/configure.ac b/configure.ac index 378e9f5..82dbe4c 100644 --- a/configure.ac +++ b/configure.ac @@ -2145,11 +2145,11 @@ if test "x$CFLAGS_FOR_TARGET" = x; then CFLAGS_FOR_TARGET=$CFLAGS case " $CFLAGS " in *" -O2 "*) ;; - *) CFLAGS_FOR_TARGET="-O2 $CFLAGS" ;; + *) CFLAGS_FOR_TARGET="-O2 $CFLAGS_FOR_TARGET" ;; esac case " $CFLAGS " in *" -g "* | *" -g3 "*) ;; - *) CFLAGS_FOR_TARGET="-g $CFLAGS" ;; + *) CFLAGS_FOR_TARGET="-g $CFLAGS_FOR_TARGET" ;; esac fi AC_SUBST(CFLAGS_FOR_TARGET) @@ -2158,11 +2158,11 @@ if test "x$CXXFLAGS_FOR_TARGET" = x; then CXXFLAGS_FOR_TARGET=$CXXFLAGS case " $CXXFLAGS " in *" -O2 "*) ;; - *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS" ;; + *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS_FOR_TARGET" ;; esac case " $CXXFLAGS " in *" -g "* | *" -g3 "*) ;; - *) CXXFLAGS_FOR_TARGET="-g $CXXFLAGS" ;; + *) CXXFLAGS_FOR_TARGET="-g $CXXFLAGS_FOR_TARGET" ;; esac fi AC_SUBST(CXXFLAGS_FOR_TARGET)