From patchwork Wed Jun 27 16:27:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 167703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E92C6B6FF8 for ; Thu, 28 Jun 2012 02:28:25 +1000 (EST) Received: from localhost ([::1]:41606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjv6N-0000vD-Mg for incoming@patchwork.ozlabs.org; Wed, 27 Jun 2012 12:28:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjv6G-0000v5-Cz for qemu-devel@nongnu.org; Wed, 27 Jun 2012 12:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sjv6A-0002dG-2G for qemu-devel@nongnu.org; Wed, 27 Jun 2012 12:28:15 -0400 Received: from goliath.siemens.de ([192.35.17.28]:17851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjv69-0002cP-PA for qemu-devel@nongnu.org; Wed, 27 Jun 2012 12:28:09 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by goliath.siemens.de (8.13.6/8.13.6) with ESMTP id q5RGRno8020365; Wed, 27 Jun 2012 18:27:50 +0200 Received: from mchn199C.mchp.siemens.de ([139.22.42.91]) by mail1.siemens.de (8.13.6/8.13.6) with SMTP id q5RGRaFd016003; Wed, 27 Jun 2012 18:27:45 +0200 From: Jan Kiszka To: Anthony Liguori , qemu-devel Date: Wed, 27 Jun 2012 18:27:23 +0200 Message-Id: X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-MIME-Autoconverted: from 8bit to quoted-printable by goliath.siemens.de id q5RGRno8020365 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.28 Cc: Liu Ping Fan , Avi Kivity , kvm , Marcelo Tosatti Subject: [Qemu-devel] [PATCH v2 1/7] i82378: Remove bogus MMIO coalescing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. Acked-by: Hervé Poussineau Signed-off-by: Jan Kiszka --- hw/i82378.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i82378.c b/hw/i82378.c index 9b11d90..2123c14 100644 --- a/hw/i82378.c +++ b/hw/i82378.c @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev) pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io); memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000); - memory_region_set_coalescing(&s->mem); pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem); /* Make I/O address read only */