From patchwork Wed Jun 27 15:57:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Weinberger X-Patchwork-Id: 167675 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C2392B6FC3 for ; Thu, 28 Jun 2012 02:00:51 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SjueL-0000YN-Bu; Wed, 27 Jun 2012 15:59:25 +0000 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SjudE-0008TW-0S for linux-mtd@lists.infradead.org; Wed, 27 Jun 2012 15:58:21 +0000 Received: (qmail 23354 invoked by uid 89); 27 Jun 2012 15:58:22 -0000 Received: by simscan 1.3.1 ppid: 23200, pid: 23351, t: 0.1238s scanners: attach: 1.3.1 clamav: 0.96.5/m:53 Received: from unknown (HELO localhost.localdomain) (richard@nod.at@212.62.202.73) by radon.swed.at with ESMTPA; 27 Jun 2012 15:58:22 -0000 From: Richard Weinberger To: linux-mtd@lists.infradead.org Subject: [PATCH 07/16] UBI: Fastmap: Address jet another TOOD Date: Wed, 27 Jun 2012 17:57:47 +0200 Message-Id: <1340812676-14460-8-git-send-email-richard@nod.at> X-Mailer: git-send-email 1.7.6.5 In-Reply-To: <1340812676-14460-1-git-send-email-richard@nod.at> References: <1340812676-14460-1-git-send-email-richard@nod.at> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: nyoushchenko@mvista.com, artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Heinz.Egger@linutronix.de, thomas.wucher@linutronix.de, shmulik.ladkani@gmail.com, Richard Weinberger , tglx@linutronix.de, Marius.Mazarel@ugal.ro, tim.bird@am.sony.com X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Writing the fastmap upon attach time if ai->is_empty=1 does not make sense. At this stage the erase worker is busy with erasing all PEBs and fastmap won't get a free anchor PEB. While detaching we write anyway a fastmap. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/attach.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c index 021c7d3..068f11a 100644 --- a/drivers/mtd/ubi/attach.c +++ b/drivers/mtd/ubi/attach.c @@ -1301,14 +1301,6 @@ int ubi_attach(struct ubi_device *ubi, int force_scan) } destroy_ai(ubi, ai); - - /* TODO: UBI auto formats the flash if it is empty (see ubi->is_empty). - * It is currently done so that every sub-system writes initializes its - * own stuff. Well, now it is only the vtbl sub-system - it creates - * empty volume table. And this is why we have "early" function for - * getting free PEBs. Fastmap should do the same - so I guess it is - * good to do it somewhere here. Also, we need to re-create the fastmap - * on-flash data-structures if they were corrupted. */ return 0; out_wl: