From patchwork Wed Jun 27 15:57:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [05/16] UBI: Fastmap: Address a TODO From: Richard Weinberger X-Patchwork-Id: 167673 Message-Id: <1340812676-14460-6-git-send-email-richard@nod.at> To: linux-mtd@lists.infradead.org Cc: nyoushchenko@mvista.com, artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Heinz.Egger@linutronix.de, thomas.wucher@linutronix.de, shmulik.ladkani@gmail.com, Richard Weinberger , tglx@linutronix.de, Marius.Mazarel@ugal.ro, tim.bird@am.sony.com Date: Wed, 27 Jun 2012 17:57:45 +0200 We cannot use an aggregate data structure because fastmaps internals parts do not have fixed positions. They depends on the number of avaliable PEBs. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/fastmap.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index a596cef..c2434cd 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -535,10 +535,6 @@ static int ubi_attach_fastmap(struct ubi_device *ubi, if (fm_pos >= fm_size) goto fail_bad; - /* TODO: this is difficult to read. Can we please have instead an - * aggregate data structure? I did not think hard on it may be you have - * a good reason for this difficult style, but on the first glance it - * does not look like. And where are all the endiness stuff? */ fmhdr = (struct ubi_fm_hdr *)(fm_raw + fm_pos); fm_pos += sizeof(*fmhdr); if (fm_pos >= fm_size)