Message ID | 20120627065309.GA25774@elgon.mountain |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
2012/6/27 Dan Carpenter <dan.carpenter@oracle.com>: > We already unlocked a few lines earlier here, so we can go directly to > drop without passing through unlock. This was introduced recently in > c5d3687f6c ('6lowpan: read data from skb safely'). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > index ad0c226..cd5007f 100644 > --- a/net/ieee802154/6lowpan.c > +++ b/net/ieee802154/6lowpan.c > @@ -771,7 +771,7 @@ lowpan_process_data(struct sk_buff *skb) > kfree(frame); > > if (lowpan_fetch_skb_u8(skb, &iphc0)) > - goto unlock_and_drop; > + goto drop; > > break; > } Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> Date: Wed, 27 Jun 2012 10:57:18 +0400 > 2012/6/27 Dan Carpenter <dan.carpenter@oracle.com>: >> We already unlocked a few lines earlier here, so we can go directly to >> drop without passing through unlock. This was introduced recently in >> c5d3687f6c ('6lowpan: read data from skb safely'). >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> ... > Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index ad0c226..cd5007f 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -771,7 +771,7 @@ lowpan_process_data(struct sk_buff *skb) kfree(frame); if (lowpan_fetch_skb_u8(skb, &iphc0)) - goto unlock_and_drop; + goto drop; break; }
We already unlocked a few lines earlier here, so we can go directly to drop without passing through unlock. This was introduced recently in c5d3687f6c ('6lowpan: read data from skb safely'). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html