Patchwork [3/3] hw/exynos4210.c: Fix misleading initialization of IROM mirror

login
register
mail settings
Submitter Evgeny Voevodin
Date June 27, 2012, 3:55 a.m.
Message ID <1340769311-19692-4-git-send-email-e.voevodin@samsung.com>
Download mbox | patch
Permalink /patch/167496/
State New
Headers show

Comments

Evgeny Voevodin - June 27, 2012, 3:55 a.m.
We want to mirror whole IROM and should pass zero instead of
EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since
memory_region_init_alias takes an offset within an original
region as an argument.

Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
 hw/exynos4210.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Maydell - June 28, 2012, 5:15 p.m.
On 27 June 2012 04:55, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> We want to mirror whole IROM and should pass zero instead of
> EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since
> memory_region_init_alias takes an offset within an original
> region as an argument.
>
> Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Patch

diff --git a/hw/exynos4210.c b/hw/exynos4210.c
index 9c20b3f..80a00b9 100644
--- a/hw/exynos4210.c
+++ b/hw/exynos4210.c
@@ -216,7 +216,7 @@  Exynos4210State *exynos4210_init(MemoryRegion *system_mem,
     /* mirror of iROM */
     memory_region_init_alias(&s->irom_alias_mem, "exynos4210.irom_alias",
                              &s->irom_mem,
-                             EXYNOS4210_IROM_BASE_ADDR,
+                             0,
                              EXYNOS4210_IROM_SIZE);
     memory_region_set_readonly(&s->irom_alias_mem, true);
     memory_region_add_subregion(system_mem, EXYNOS4210_IROM_MIRROR_BASE_ADDR,