Patchwork [v2] ubifs: Fix build warning

login
register
mail settings
Submitter Alexandre Pereira da Silva
Date June 25, 2012, 8:47 p.m.
Message ID <1340657269-8588-1-git-send-email-aletes.xgr@gmail.com>
Download mbox | patch
Permalink /patch/167241/
State New
Headers show

Comments

Alexandre Pereira da Silva - June 25, 2012, 8:47 p.m.
Fix:
fs/ubifs/dir.c: In function 'ubifs_rename':
fs/ubifs/dir.c:972:15: warning: 'saved_nlink' may be used uninitialized
in this function

Use gcc uninitialized_var macro to avoid bogus warning

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
Applies to v3.5-rc4

Changes since v1:
Use uninitialized_var macro

 fs/ubifs/dir.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Artem Bityutskiy - June 29, 2012, 11:07 a.m.
On Mon, 2012-06-25 at 17:47 -0300, Alexandre Pereira da Silva wrote:
>  #include "ubifs.h"
> +#include <linux/compiler.h>

This is not needed, I've removed this chunk and pushed to
linux-ubifs.git, thanks!

Patch

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index a6d42ef..40c2d04 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -41,6 +41,7 @@ 
  */
 
 #include "ubifs.h"
+#include <linux/compiler.h>
 
 /**
  * inherit_flags - inherit flags of the parent inode.
@@ -969,7 +970,7 @@  static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry,
 	struct ubifs_budget_req ino_req = { .dirtied_ino = 1,
 			.dirtied_ino_d = ALIGN(old_inode_ui->data_len, 8) };
 	struct timespec time;
-	unsigned int saved_nlink;
+	unsigned int uninitialized_var(saved_nlink);
 
 	/*
 	 * Budget request settings: deletion direntry, new direntry, removing