Patchwork [v2,4/4] monitor: Use TARGET_PRI*PHYS to avoid TARGET_PHYS_ADDR_BITS ifdef

login
register
mail settings
Submitter Peter Maydell
Date June 25, 2012, 3:52 p.m.
Message ID <1340639544-26520-5-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/167144/
State New
Headers show

Comments

Peter Maydell - June 25, 2012, 3:52 p.m.
Now we have TARGET_PRI*PHYS for printing target_phys_addr_t values,
we can use them in monitor.c rather than having duplicate code
in two arms of a TARGET_PHYS_ADDR_BITS ifdef.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 monitor.c |   29 ++++-------------------------
 1 files changed, 4 insertions(+), 25 deletions(-)
Andreas Färber - June 25, 2012, 4:45 p.m.
Am 25.06.2012 17:52, schrieb Peter Maydell:
> Now we have TARGET_PRI*PHYS for printing target_phys_addr_t values,
> we can use them in monitor.c rather than having duplicate code
> in two arms of a TARGET_PHYS_ADDR_BITS ifdef.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Andreas Färber <afaerber@suse.de>

/-F

Patch

diff --git a/monitor.c b/monitor.c
index f6107ba..188c03d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1262,45 +1262,24 @@  static void do_print(Monitor *mon, const QDict *qdict)
     int format = qdict_get_int(qdict, "format");
     target_phys_addr_t val = qdict_get_int(qdict, "val");
 
-#if TARGET_PHYS_ADDR_BITS == 32
     switch(format) {
     case 'o':
-        monitor_printf(mon, "%#o", val);
+        monitor_printf(mon, "%#" TARGET_PRIoPHYS, val);
         break;
     case 'x':
-        monitor_printf(mon, "%#x", val);
+        monitor_printf(mon, "%#" TARGET_PRIxPHYS, val);
         break;
     case 'u':
-        monitor_printf(mon, "%u", val);
+        monitor_printf(mon, "%" TARGET_PRIuPHYS, val);
         break;
     default:
     case 'd':
-        monitor_printf(mon, "%d", val);
+        monitor_printf(mon, "%" TARGET_PRIdPHYS, val);
         break;
     case 'c':
         monitor_printc(mon, val);
         break;
     }
-#else
-    switch(format) {
-    case 'o':
-        monitor_printf(mon, "%#" PRIo64, val);
-        break;
-    case 'x':
-        monitor_printf(mon, "%#" PRIx64, val);
-        break;
-    case 'u':
-        monitor_printf(mon, "%" PRIu64, val);
-        break;
-    default:
-    case 'd':
-        monitor_printf(mon, "%" PRId64, val);
-        break;
-    case 'c':
-        monitor_printc(mon, val);
-        break;
-    }
-#endif
     monitor_printf(mon, "\n");
 }