diff mbox

[2/4] target-xtensa: drop usage of prev_debug_excp_handler

Message ID 1340632507-29692-3-git-send-email-imammedo@redhat.com
State New
Headers show

Commit Message

Igor Mammedov June 25, 2012, 1:55 p.m. UTC 
Chains of exception handlers are currently unused feature. Dropping it
to be consistent with target-i386 but it may simplify qom-ifying CPU
in future like for target-i386.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target-xtensa/helper.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Max Filippov June 25, 2012, 2:06 p.m. UTC | #1 
On Mon, Jun 25, 2012 at 5:55 PM, Igor Mammedov <imammedo@redhat.com> wrote:
> Chains of exception handlers are currently unused feature. Dropping it
> to be consistent with target-i386 but it may simplify qom-ifying CPU
> in future like for target-i386.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  target-xtensa/helper.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>
diff mbox

Patch

diff --git a/target-xtensa/helper.c b/target-xtensa/helper.c
index 044ce18..d5bb171 100644
--- a/target-xtensa/helper.c
+++ b/target-xtensa/helper.c
@@ -54,8 +54,6 @@  static uint32_t check_hw_breakpoints(CPUXtensaState *env)
     return 0;
 }
 
-static CPUDebugExcpHandler *prev_debug_excp_handler;
-
 static void breakpoint_handler(CPUXtensaState *env)
 {
     if (env->watchpoint_hit) {
@@ -70,9 +68,6 @@  static void breakpoint_handler(CPUXtensaState *env)
             cpu_resume_from_signal(env, NULL);
         }
     }
-    if (prev_debug_excp_handler) {
-        prev_debug_excp_handler(env);
-    }
 }
 
 XtensaCPU *cpu_xtensa_init(const char *cpu_model)
@@ -105,8 +100,7 @@  XtensaCPU *cpu_xtensa_init(const char *cpu_model)
 
     if (!debug_handler_inited && tcg_enabled()) {
         debug_handler_inited = 1;
-        prev_debug_excp_handler =
-            cpu_set_debug_excp_handler(breakpoint_handler);
+        cpu_set_debug_excp_handler(breakpoint_handler);
     }
 
     xtensa_irq_init(env);