From patchwork Mon Jun 25 09:06:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] jbd: rename get_transaction to init_transaction From: Yuanhan Liu X-Patchwork-Id: 167011 Message-Id: <1340615207-20548-1-git-send-email-yliu.null@gmail.com> To: akpm@linux-foundation.org Cc: linux-ext4@vger.kernel.org, Yuanhan Liu Date: Mon, 25 Jun 2012 17:06:47 +0800 get_transaction() does nothing but initialization. So, rename it and also fix the comments. Signed-off-by: Yuanhan Liu --- fs/jbd/transaction.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index febc10d..82f8a7a 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c @@ -31,12 +31,12 @@ static void __journal_temp_unlink_buffer(struct journal_head *jh); /* - * get_transaction: obtain a new transaction_t object. + * init_transaction: Initialise a new transaction_t object. * - * Simply allocate and initialise a new transaction. Create it in - * RUNNING state and add it to the current journal (which should not - * have an existing running transaction: we only make a new transaction - * once we have started to commit the old one). + * Simply initialise a new transaction. initialise it in RUNNING state + * and add it to the current journal (which should not have an existing + * running transaction: we only make a new transaction once we have + * started to commit the old one). * * Preconditions: * The journal MUST be locked. We don't perform atomic mallocs on the @@ -46,8 +46,7 @@ static void __journal_temp_unlink_buffer(struct journal_head *jh); * Called under j_state_lock */ -static transaction_t * -get_transaction(journal_t *journal, transaction_t *transaction) +static void init_transaction(journal_t *journal, transaction_t *transaction) { transaction->t_journal = journal; transaction->t_state = T_RUNNING; @@ -63,8 +62,6 @@ get_transaction(journal_t *journal, transaction_t *transaction) J_ASSERT(journal->j_running_transaction == NULL); journal->j_running_transaction = transaction; - - return transaction; } /* @@ -137,7 +134,7 @@ repeat_locked: spin_unlock(&journal->j_state_lock); goto alloc_transaction; } - get_transaction(journal, new_transaction); + init_transaction(journal, new_transaction); new_transaction = NULL; }