From patchwork Sun Jun 24 14:24:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 166886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 08284B6FA1 for ; Mon, 25 Jun 2012 00:25:28 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1341152730; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:From:Date: Message-ID:Subject:To:Cc:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=6eVLb92RBIQNcQ9MY7TfyrRgiJU=; b=l1iuHw75aTta0pC Ho+xus0RN+hkogP1dOOGZDzi/XK5eOwSOLzcIejs8JPiAgQFuHMqyZM5v5fte+X2 Iqql3g6/paQuTo6u02ya7a28ZxzBQql7m6aK957kC+P1dXGCByNZQanbh11yGlUJ X6bFJofFFFdNUNJi/6EJQm/lGN4g= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:In-Reply-To:References:From:Date:Message-ID:Subject:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Oyfs+D0IgJWJ8NoWJqt6hr5G0yhXa7rol4LWTZDr/7PkctS7DC8kFaEVLb2HEv lAkubSBH3IcQwpRggSLYxr4S2cM25/DK7xKmJY/5xFSoVDlF03tVe4JSRYDoqdn+ b5Z6mHX1aL/n2irLLUYnS87SBnthnOs2SwzrXAip5L2D8=; Received: (qmail 21730 invoked by alias); 24 Jun 2012 14:25:25 -0000 Received: (qmail 21719 invoked by uid 22791); 24 Jun 2012 14:25:24 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KAM_STOCKGEN, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 Jun 2012 14:25:12 +0000 Received: by lbol5 with SMTP id l5so5719399lbo.20 for ; Sun, 24 Jun 2012 07:25:10 -0700 (PDT) Received: by 10.152.131.68 with SMTP id ok4mr8639443lab.47.1340547910609; Sun, 24 Jun 2012 07:25:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.4.229 with HTTP; Sun, 24 Jun 2012 07:24:49 -0700 (PDT) In-Reply-To: References: From: Steven Bosscher Date: Sun, 24 Jun 2012 16:24:49 +0200 Message-ID: Subject: Re: [patch] Remove and poison a few more old target macros To: GCC Patches Cc: Michael Eager , DJ Delorie X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sun, Jun 24, 2012 at 3:42 PM, Steven Bosscher wrote: > Like the ones before: they are unused. > Will commit as an obvious cleanup in a few days' time. ...and one more... * system.h (USE_COMMON_FOR_ONE_ONLY): Poison. * defaults.h (USE_COMMON_FOR_ONE_ONLY): Do not provide default. * config/darwin.h (USE_COMMON_FOR_ONE_ONLY): Do not define. Index: system.h =================================================================== --- system.h (revision 188856) +++ system.h (working copy) @@ -888,7 +888,7 @@ extern void fancy_abort (const char *, int, const PREFERRED_OUTPUT_RELOAD_CLASS SYSTEM_INCLUDE_DIR \ STANDARD_INCLUDE_DIR STANDARD_INCLUDE_COMPONENT \ LINK_ELIMINATE_DUPLICATE_LDIRECTORIES MIPS_DEBUGGING_INFO \ - IDENT_ASM_OP + IDENT_ASM_OP USE_COMMON_FOR_ONE_ONLY /* Hooks that are no longer used. */ #pragma GCC poison LANG_HOOKS_FUNCTION_MARK LANG_HOOKS_FUNCTION_FREE \ Index: defaults.h =================================================================== --- defaults.h (revision 188856) +++ defaults.h (working copy) @@ -332,12 +332,6 @@ see the files COPYING3 and COPYING.RUNTIME respect # endif #endif -/* Determines whether we may use common symbols to represent one-only - semantics (a.k.a. "vague linkage"). */ -#ifndef USE_COMMON_FOR_ONE_ONLY -# define USE_COMMON_FOR_ONE_ONLY 1 -#endif - /* By default we can assume that all global symbols are in one namespace, across all shared libraries. */ #ifndef MULTIPLE_SYMBOL_SPACES Index: config/darwin.h =================================================================== --- config/darwin.h (revision 188856) +++ config/darwin.h (working copy) @@ -464,13 +464,6 @@ extern GTY(()) int darwin_ms_struct; links to, so there's no need for weak-ness for that. */ #define GTHREAD_USE_WEAK 0 -/* The Darwin linker imposes two limitations on common symbols: they - can't have hidden visibility, and they can't appear in dylibs. As - a consequence, we should never use common symbols to represent - vague linkage. */ -#undef USE_COMMON_FOR_ONE_ONLY -#define USE_COMMON_FOR_ONE_ONLY 0 - /* The Darwin linker doesn't want coalesced symbols to appear in a static archive's table of contents. */ #undef TARGET_WEAK_NOT_IN_ARCHIVE_TOC