Patchwork target-ppc: Fix build with --enable-debug

login
register
mail settings
Submitter Stefan Weil
Date June 24, 2012, 2:04 p.m.
Message ID <1340546657-12747-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/166882/
State Accepted
Headers show

Comments

Stefan Weil - June 24, 2012, 2:04 p.m.
The order of the arguments was wrong (copy+paste error).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

Hi Alex, hi Blue,

there is still one more bug for target-ppc with --enable-debug,
so strictly speaking, the subject is not correct: the patch
fixes the build only partially.

Regards,
Stefan

 target-ppc/translate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Blue Swirl - June 24, 2012, 4:04 p.m.
On Sun, Jun 24, 2012 at 2:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
> The order of the arguments was wrong (copy+paste error).

Confirmed, a bug with
d0f1562d6ace0fdb7d2db190dd5a9a2e7492c3b3

>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Hi Alex, hi Blue,
>
> there is still one more bug for target-ppc with --enable-debug,
> so strictly speaking, the subject is not correct: the patch
> fixes the build only partially.
>
> Regards,
> Stefan
>
>  target-ppc/translate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 73ee74b..91eb7a0 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -5794,7 +5794,7 @@ static void gen_mtdcrux(DisasContext *ctx)
>  {
>     /* NIP cannot be restored if the memory exception comes from an helper */
>     gen_update_nip(ctx, ctx->nip - 4);
> -    gen_helper_store_dcr(cpu_gpr[rA(ctx->opcode)], cpu_env,
> +    gen_helper_store_dcr(cpu_env, cpu_gpr[rA(ctx->opcode)],
>                          cpu_gpr[rS(ctx->opcode)]);
>     /* Note: Rc update flag set leads to undefined state of Rc0 */
>  }
> --
> 1.7.10
>

Patch

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 73ee74b..91eb7a0 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -5794,7 +5794,7 @@  static void gen_mtdcrux(DisasContext *ctx)
 {
     /* NIP cannot be restored if the memory exception comes from an helper */
     gen_update_nip(ctx, ctx->nip - 4);
-    gen_helper_store_dcr(cpu_gpr[rA(ctx->opcode)], cpu_env,
+    gen_helper_store_dcr(cpu_env, cpu_gpr[rA(ctx->opcode)],
                          cpu_gpr[rS(ctx->opcode)]);
     /* Note: Rc update flag set leads to undefined state of Rc0 */
 }