From patchwork Fri Jun 22 05:42:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 166507 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id DA462B6F9F for ; Fri, 22 Jun 2012 15:45:18 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DE4DB8C9EF; Fri, 22 Jun 2012 05:45:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PO4CycV4FMGc; Fri, 22 Jun 2012 05:45:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 05A4C8CA8A; Fri, 22 Jun 2012 05:44:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DB2008F753 for ; Fri, 22 Jun 2012 05:43:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 912DB8C9EB for ; Fri, 22 Jun 2012 05:43:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f9-nOGY24pSw for ; Fri, 22 Jun 2012 05:43:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id D739A8CA0F for ; Fri, 22 Jun 2012 05:43:26 +0000 (UTC) Received: by mail-ee0-f43.google.com with SMTP id e50so809805eek.16 for ; Thu, 21 Jun 2012 22:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:content-transfer-encoding:subject :x-mercurial-node:message-id:in-reply-to:references:user-agent:date :from:to:cc; bh=r1yUAFuBXu55NYrsiwBsSauCbMWKEviMmomZL40mknI=; b=mY+ep6lWlfAD+8fOxWfSwuooglEcEwe0zlvt4qxeUs5/jViWbqZE10419epm638n5I weqBEuTzx/gr/tAN9wYupf69Ervi6AlhIxE7t5y0bFVEjcUIYbnwYSxYP6hUVCBwnWob 0X/Yf9IxnkY+DJkakEoB0SY9TKzk+yGzalXqfV6pI1rFv+LffuIpw9r9Tqwvg0H1QvGa X+JkBBzWIdjCQZwHWtJ5Cym4degjetLMQy/3kArB1XgklpwpC4eE3dZX836QL2x13TOC EjPW8L3GZKpG9WNEa7UWGmZCCp+Ca+ZVeOckzYJIkVZso5zlaAlQ1hEzxsKJexA/bzy0 nWZA== Received: by 10.14.101.79 with SMTP id a55mr161604eeg.32.1340343806479; Thu, 21 Jun 2012 22:43:26 -0700 (PDT) Received: from [127.0.1.1] (d54C62EEB.access.telenet.be. [84.198.46.235]) by mx.google.com with ESMTPS id c51sm109212458eei.12.2012.06.21.22.43.25 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jun 2012 22:43:25 -0700 (PDT) MIME-Version: 1.0 X-Mercurial-Node: cdd902c8ebab6cecb83120bc8f60e5b4a8647282 Message-Id: In-Reply-To: References: User-Agent: Mercurial-patchbomb/2.0.2 Date: Fri, 22 Jun 2012 07:42:39 +0200 From: Thomas De Schampheleire To: buildroot@busybox.net Subject: [Buildroot] [PATCH 6 of 6 resend] toolchain-external: line up comments with reality X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Line-up with changes from commit 3367d5ce770ac409e7b3f5bba2c7ed1a819b3ef7 "external-toolchain: run checks even on extracted toolchains" Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- toolchain/toolchain-external/ext-tool.mk | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk --- a/toolchain/toolchain-external/ext-tool.mk +++ b/toolchain/toolchain-external/ext-tool.mk @@ -14,11 +14,10 @@ # # The basic principle is the following # -# 1. a. For toolchains downloaded from the Web, Buildroot already -# knows their configuration, so it just downloads them and extract -# them in $(TOOLCHAIN_EXTERNAL_DIR). +# 1. If the toolchain is not pre-installed, download and extract it +# in $(TOOLCHAIN_EXTERNAL_DIR). # -# 1. b. For pre-installed toolchains, perform some checks on the +# 2. For all external toolchains, perform some checks on the # conformity between the toolchain configuration described in the # Buildroot menuconfig system, and the real configuration of the # external toolchain. This is for example important to make sure that @@ -30,19 +29,19 @@ # options. And at configuration time, we are not able to retrieve the # external toolchain configuration. # -# 2. Copy the libraries needed at runtime to the target directory, +# 3. Copy the libraries needed at runtime to the target directory, # $(TARGET_DIR). Obviously, things such as the C library, the dynamic # loader and a few other utility libraries are needed if dynamic # applications are to be executed on the target system. # -# 3. Copy the libraries and headers to the staging directory. This +# 4. Copy the libraries and headers to the staging directory. This # will allow all further calls to gcc to be made using --sysroot # $(STAGING_DIR), which greatly simplifies the compilation of the # packages when using external toolchains. So in the end, only the # cross-compiler binaries remains external, all libraries and headers # are imported into the Buildroot tree. # -# 4. Build a toolchain wrapper which executes the external toolchain +# 5. Build a toolchain wrapper which executes the external toolchain # with a number of arguments (sysroot/march/mtune/..) hardcoded, # so we're sure the correct configuration is always used and the # toolchain behaves similar to an internal toolchain.