Message ID | fef39461f25270f81f06.1340343522@beantl019720 |
---|---|
State | Accepted |
Headers | show |
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:
Thomas> The original 'source-check' target first selects all packages,
Thomas> and then checks whether the package tarballs can be found. This
Thomas> is useful for Buildroot maintainers, but less useful for
Thomas> developers working on a specific project. The latter only care
Thomas> about the packages used in that project.
Thomas> This patch removes the allyesconfig dependency to source-check
Thomas> so that only selected packages are checked. The original
Thomas> behavior is moved to a new target 'source-check-all'.
Committed, thanks - But as we don't have the 'select-all-packages'
functionality for 'make source' which is the parallel of 'make
source-check', I decided to just get rid of source-check-all
completely.
People can always do make allyesconfig; make source-check if they want
the old behaviour.
Op 23 jun. 2012 23:32 schreef "Peter Korsgaard" <jacmet@sunsite.dk> het volgende: > > >>>>> "Thomas" == Thomas De Schampheleire < patrickdepinguin+buildroot@gmail.com> writes: > > Thomas> The original 'source-check' target first selects all packages, > Thomas> and then checks whether the package tarballs can be found. This > Thomas> is useful for Buildroot maintainers, but less useful for > Thomas> developers working on a specific project. The latter only care > Thomas> about the packages used in that project. > > Thomas> This patch removes the allyesconfig dependency to source-check > Thomas> so that only selected packages are checked. The original > Thomas> behavior is moved to a new target 'source-check-all'. > > Committed, thanks - But as we don't have the 'select-all-packages' > functionality for 'make source' which is the parallel of 'make > source-check', I decided to just get rid of source-check-all > completely. > > People can always do make allyesconfig; make source-check if they want > the old behaviour. Ok, no problem, thanks. Best regards, Thomas
diff --git a/Makefile b/Makefile --- a/Makefile +++ b/Makefile @@ -48,7 +48,7 @@ export BR2_VERSION_FULL:=$(BR2_VERSION)$ noconfig_targets:=menuconfig nconfig gconfig xconfig config oldconfig randconfig \ defconfig %_defconfig savedefconfig allyesconfig allnoconfig silentoldconfig release \ randpackageconfig allyespackageconfig allnopackageconfig \ - source-check print-version + source-check source-check-all print-version # Strip quotes and then whitespaces qstrip=$(strip $(subst ",,$(1))) @@ -585,7 +585,8 @@ savedefconfig: $(BUILD_DIR)/buildroot-co @$(COMMON_CONFIG_ENV) $< --savedefconfig=$(CONFIG_DIR)/defconfig $(CONFIG_CONFIG_IN) # check if download URLs are outdated -source-check: allyesconfig +source-check-all: allyesconfig source-check +source-check: $(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source endif # ifeq ($(BR2_HAVE_DOT_CONFIG),y) @@ -672,7 +673,8 @@ endif @echo @echo 'Miscellaneous:' @echo ' source - download all sources needed for offline-build' - @echo ' source-check - check all packages for valid download URLs' + @echo ' source-check - check selected packages for valid download URLs' + @echo ' source-check-all - check all packages for valid download URLs' @echo ' external-deps - list external packages used' @echo @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build'