Patchwork [resend3] source-check: change behavior to check only selected packages / add source-check-all

login
register
mail settings
Submitter Thomas De Schampheleire
Date June 22, 2012, 5:38 a.m.
Message ID <fef39461f25270f81f06.1340343522@beantl019720>
Download mbox | patch
Permalink /patch/166503/
State Accepted
Headers show

Comments

Thomas De Schampheleire - June 22, 2012, 5:38 a.m.
The original 'source-check' target first selects all packages, and then checks
whether the package tarballs can be found. This is useful for Buildroot
maintainers, but less useful for developers working on a specific project. The
latter only care about the packages used in that project.

This patch removes the allyesconfig dependency to source-check so that only
selected packages are checked. The original behavior is moved to a new target
'source-check-all'.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
 Makefile |  8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
Peter Korsgaard - June 23, 2012, 9:32 p.m.
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> The original 'source-check' target first selects all packages,
 Thomas> and then checks whether the package tarballs can be found. This
 Thomas> is useful for Buildroot maintainers, but less useful for
 Thomas> developers working on a specific project. The latter only care
 Thomas> about the packages used in that project.

 Thomas> This patch removes the allyesconfig dependency to source-check
 Thomas> so that only selected packages are checked. The original
 Thomas> behavior is moved to a new target 'source-check-all'.

Committed, thanks - But as we don't have the 'select-all-packages'
functionality for 'make source' which is the parallel of 'make
source-check', I decided to just get rid of source-check-all
completely.

People can always do make allyesconfig; make source-check if they want
the old behaviour.
Thomas De Schampheleire - June 24, 2012, 8:12 a.m.
Op 23 jun. 2012 23:32 schreef "Peter Korsgaard" <jacmet@sunsite.dk> het
volgende:
>
> >>>>> "Thomas" == Thomas De Schampheleire <
patrickdepinguin+buildroot@gmail.com> writes:
>
>  Thomas> The original 'source-check' target first selects all packages,
>  Thomas> and then checks whether the package tarballs can be found. This
>  Thomas> is useful for Buildroot maintainers, but less useful for
>  Thomas> developers working on a specific project. The latter only care
>  Thomas> about the packages used in that project.
>
>  Thomas> This patch removes the allyesconfig dependency to source-check
>  Thomas> so that only selected packages are checked. The original
>  Thomas> behavior is moved to a new target 'source-check-all'.
>
> Committed, thanks - But as we don't have the 'select-all-packages'
> functionality for 'make source' which is the parallel of 'make
> source-check', I decided to just get rid of source-check-all
> completely.
>
> People can always do make allyesconfig; make source-check if they want
> the old behaviour.

Ok, no problem, thanks.

Best regards,
Thomas

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -48,7 +48,7 @@  export BR2_VERSION_FULL:=$(BR2_VERSION)$
 noconfig_targets:=menuconfig nconfig gconfig xconfig config oldconfig randconfig \
 	defconfig %_defconfig savedefconfig allyesconfig allnoconfig silentoldconfig release \
 	randpackageconfig allyespackageconfig allnopackageconfig \
-	source-check print-version
+	source-check source-check-all print-version
 
 # Strip quotes and then whitespaces
 qstrip=$(strip $(subst ",,$(1)))
@@ -585,7 +585,8 @@  savedefconfig: $(BUILD_DIR)/buildroot-co
 	@$(COMMON_CONFIG_ENV) $< --savedefconfig=$(CONFIG_DIR)/defconfig $(CONFIG_CONFIG_IN)
 
 # check if download URLs are outdated
-source-check: allyesconfig
+source-check-all: allyesconfig source-check
+source-check:
 	$(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source
 
 endif # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
@@ -672,7 +673,8 @@  endif
 	@echo
 	@echo 'Miscellaneous:'
 	@echo '  source                 - download all sources needed for offline-build'
-	@echo '  source-check           - check all packages for valid download URLs'
+	@echo '  source-check           - check selected packages for valid download URLs'
+	@echo '  source-check-all       - check all packages for valid download URLs'
 	@echo '  external-deps          - list external packages used'
 	@echo
 	@echo '  make V=0|1             - 0 => quiet build (default), 1 => verbose build'