diff mbox

[U-Boot,08/24] mxc_i2c: remove redundant read

Message ID 1340338339-11626-8-git-send-email-troy.kisky@boundarydevices.com
State Accepted
Commit d45e75b10cff8b388c9ec2e9fe3d4484bf1ba943
Delegated to: Heiko Schocher
Headers show

Commit Message

Troy Kisky June 22, 2012, 4:12 a.m. UTC 
wait_for_sr_state returns i2sr on success
so no need to read again.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
 drivers/i2c/mxc_i2c.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Marek Vasut June 22, 2012, 5:02 p.m. UTC | #1 
Dear Troy Kisky,

> wait_for_sr_state returns i2sr on success
> so no need to read again.
> 
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/i2c/mxc_i2c.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index 7b1b75c..9063d1e 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -193,7 +193,6 @@ static int tx_byte(struct mxc_i2c_regs *i2c_regs, u8
> byte) ret = wait_for_sr_state(i2c_regs, ST_IIF);
>  	if (ret < 0)
>  		return ret;
> -	ret = readb(&i2c_regs->i2sr);
>  	if (ret & I2SR_RX_NO_AK)
>  		return -ENODEV;
>  	return 0;

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index 7b1b75c..9063d1e 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -193,7 +193,6 @@  static int tx_byte(struct mxc_i2c_regs *i2c_regs, u8 byte)
 	ret = wait_for_sr_state(i2c_regs, ST_IIF);
 	if (ret < 0)
 		return ret;
-	ret = readb(&i2c_regs->i2sr);
 	if (ret & I2SR_RX_NO_AK)
 		return -ENODEV;
 	return 0;