From patchwork Thu Jun 21 21:50:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Weinberger X-Patchwork-Id: 166411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 04954B6EE7 for ; Fri, 22 Jun 2012 07:52:50 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1ShpHz-0002Bx-JP; Thu, 21 Jun 2012 21:51:43 +0000 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1ShpGs-0001lU-M4 for linux-mtd@lists.infradead.org; Thu, 21 Jun 2012 21:50:36 +0000 Received: (qmail 27635 invoked by uid 89); 21 Jun 2012 21:51:00 -0000 Received: by simscan 1.3.1 ppid: 27329, pid: 27630, t: 0.1500s scanners: attach: 1.3.1 clamav: 0.96.5/m:53 Received: from unknown (HELO localhost.localdomain) (richard@nod.at@212.62.202.73) by radon.swed.at with ESMTPA; 21 Jun 2012 21:51:00 -0000 From: Richard Weinberger To: linux-mtd@lists.infradead.org Subject: [PATCH 15/15] UBI: Fastmap: Write a fastmap also while detaching. Date: Thu, 21 Jun 2012 23:50:08 +0200 Message-Id: <1340315408-27375-16-git-send-email-richard@nod.at> X-Mailer: git-send-email 1.7.6.5 In-Reply-To: <1340315408-27375-1-git-send-email-richard@nod.at> References: <1340315408-27375-1-git-send-email-richard@nod.at> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Heinz.Egger@linutronix.de, thomas.wucher@linutronix.de, shmulik.ladkani@gmail.com, Richard Weinberger , tglx@linutronix.de, Marius.Mazarel@ugal.ro, tim.bird@am.sony.com X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org To ensure that fastmap knows all EC values we have to do this. Otherwise fastmap my miss EC updates. E.g: If the WL sub-system moves data from PEB A to PEB B. It picks B from the WL pool, moves the data to it an eraes A. If we detach now (or a power cut happens) the new EC value is lost. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/build.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 186bc19..611d0c4 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1051,6 +1051,8 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway) ubi_notify_all(ubi, UBI_VOLUME_REMOVED, NULL); dbg_msg("detaching mtd%d from ubi%d", ubi->mtd->index, ubi_num); + ubi_update_fastmap(ubi); + /* * Before freeing anything, we have to stop the background thread to * prevent it from doing anything on this device while we are freeing. @@ -1058,10 +1060,6 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway) if (ubi->bgt_thread) kthread_stop(ubi->bgt_thread); - /* If no fastmap is present on the FLASH write one. */ - if (!ubi->fm) - ubi_update_fastmap(ubi); - /* * Get a reference to the device in order to prevent 'dev_release()' * from freeing the @ubi object.