Patchwork debian: Fix up the dependency of debian packages

login
register
mail settings
Submitter Keng-Yu Lin
Date June 21, 2012, 6:48 p.m.
Message ID <1340304485-20127-1-git-send-email-kengyu@canonical.com>
Download mbox | patch
Permalink /patch/166374/
State Accepted
Headers show

Comments

Keng-Yu Lin - June 21, 2012, 6:48 p.m.
fwts package should depend on the library packages and they should of the same
version.

fwts-frontend should depend on fwts.

Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
---
 debian/control |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Colin King - June 22, 2012, 8 a.m.
On 21/06/12 19:48, Keng-Yu Lin wrote:
> fwts package should depend on the library packages and they should of the same
> version.
>
> fwts-frontend should depend on fwts.
>
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>   debian/control |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index 05a796e..b9eace1 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -8,7 +8,7 @@ Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool, libpcre3-dev
>
>   Package: fwts
>   Architecture: any
> -Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
> +Depends: libfwtsiasl1 (= ${binary:Version}), libfwtsacpica1 (= ${binary:Version}), libfwts1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, pciutils
>   Suggests: dmidecode, net-tools, wireless-tools, bluez, xinput, pulseaudio-utils
>   Description: FirmWare Test Suite
>    This is a firmware test suite that performs sanity checks on Intel/AMD
> @@ -47,7 +47,7 @@ Description: FirmWare Test Suite core support library
>   Package: fwts-frontend
>   Architecture: all
>   Priority: optional
> -Depends: ${shlibs:Depends}, ${misc:Depends}, dialog
> +Depends: ${shlibs:Depends}, ${misc:Depends}, dialog, fwts
>   Description: Firmware Test Suite frontend interface
>    This is a dialog based interface designed to provide an easy to use method
>    to execute tests via Firmware Test Suite and is also used as the primary
>
Thanks for this Keng-Yu.

Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung - June 22, 2012, 8:03 a.m.
On 06/22/2012 02:48 AM, Keng-Yu Lin wrote:
> fwts package should depend on the library packages and they should of the same
> version.
>
> fwts-frontend should depend on fwts.
>
> Signed-off-by: Keng-Yu Lin<kengyu@canonical.com>
> ---
>   debian/control |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index 05a796e..b9eace1 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -8,7 +8,7 @@ Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool, libpcre3-dev
>
>   Package: fwts
>   Architecture: any
> -Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
> +Depends: libfwtsiasl1 (= ${binary:Version}), libfwtsacpica1 (= ${binary:Version}), libfwts1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, pciutils
>   Suggests: dmidecode, net-tools, wireless-tools, bluez, xinput, pulseaudio-utils
>   Description: FirmWare Test Suite
>    This is a firmware test suite that performs sanity checks on Intel/AMD
> @@ -47,7 +47,7 @@ Description: FirmWare Test Suite core support library
>   Package: fwts-frontend
>   Architecture: all
>   Priority: optional
> -Depends: ${shlibs:Depends}, ${misc:Depends}, dialog
> +Depends: ${shlibs:Depends}, ${misc:Depends}, dialog, fwts
>   Description: Firmware Test Suite frontend interface
>    This is a dialog based interface designed to provide an easy to use method
>    to execute tests via Firmware Test Suite and is also used as the primary

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu - June 22, 2012, 8:58 a.m.
On 06/22/2012 02:48 AM, Keng-Yu Lin wrote:
> fwts package should depend on the library packages and they should of the same
> version.
>
> fwts-frontend should depend on fwts.
>
> Signed-off-by: Keng-Yu Lin<kengyu@canonical.com>
> ---
>   debian/control |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index 05a796e..b9eace1 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -8,7 +8,7 @@ Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool, libpcre3-dev
>
>   Package: fwts
>   Architecture: any
> -Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
> +Depends: libfwtsiasl1 (= ${binary:Version}), libfwtsacpica1 (= ${binary:Version}), libfwts1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, pciutils
>   Suggests: dmidecode, net-tools, wireless-tools, bluez, xinput, pulseaudio-utils
>   Description: FirmWare Test Suite
>    This is a firmware test suite that performs sanity checks on Intel/AMD
> @@ -47,7 +47,7 @@ Description: FirmWare Test Suite core support library
>   Package: fwts-frontend
>   Architecture: all
>   Priority: optional
> -Depends: ${shlibs:Depends}, ${misc:Depends}, dialog
> +Depends: ${shlibs:Depends}, ${misc:Depends}, dialog, fwts
>   Description: Firmware Test Suite frontend interface
>    This is a dialog based interface designed to provide an easy to use method
>    to execute tests via Firmware Test Suite and is also used as the primary

Hi Keng-Yu,

I checked the version, it seems 0.25.03. Is that what you expect?
ivanhu@ivanhu-ThinkPad-X220:~$ fwts -v
fwts, Version V0.25.03, Tue Jun 19 13:38:26 CST 2012

Best regards,
Ivan

Patch

diff --git a/debian/control b/debian/control
index 05a796e..b9eace1 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@  Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool, libpcre3-dev
 
 Package: fwts
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils 
+Depends: libfwtsiasl1 (= ${binary:Version}), libfwtsacpica1 (= ${binary:Version}), libfwts1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}, pciutils 
 Suggests: dmidecode, net-tools, wireless-tools, bluez, xinput, pulseaudio-utils
 Description: FirmWare Test Suite
  This is a firmware test suite that performs sanity checks on Intel/AMD 
@@ -47,7 +47,7 @@  Description: FirmWare Test Suite core support library
 Package: fwts-frontend
 Architecture: all
 Priority: optional
-Depends: ${shlibs:Depends}, ${misc:Depends}, dialog
+Depends: ${shlibs:Depends}, ${misc:Depends}, dialog, fwts
 Description: Firmware Test Suite frontend interface
  This is a dialog based interface designed to provide an easy to use method
  to execute tests via Firmware Test Suite and is also used as the primary