Patchwork [v2,01/11] dt: make setprop argument static

login
register
mail settings
Submitter Alexander Graf
Date June 21, 2012, 1:33 p.m.
Message ID <1340285640-28669-2-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/166312/
State New
Headers show

Comments

Alexander Graf - June 21, 2012, 1:33 p.m.
Whatever we pass in to qemu_devtree_setprop to put into the device tree
will not get modified by that function, so it can easily be declared const.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 device_tree.c |    2 +-
 device_tree.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Peter A. G. Crosthwaite - June 23, 2012, 12:47 a.m.
On Thu, Jun 21, 2012 at 11:33 PM, Alexander Graf <agraf@suse.de> wrote:
> Whatever we pass in to qemu_devtree_setprop to put into the device tree
> will not get modified by that function, so it can easily be declared const.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

Reviewed-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

> ---
>  device_tree.c |    2 +-
>  device_tree.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index acae53e..b366fdd 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -127,7 +127,7 @@ static int findnode_nofail(void *fdt, const char *node_path)
>  }
>
>  int qemu_devtree_setprop(void *fdt, const char *node_path,
> -                         const char *property, void *val_array, int size)
> +                         const char *property, const void *val_array, int size)
>  {
>     int r;
>
> diff --git a/device_tree.h b/device_tree.h
> index 4898d95..2244270 100644
> --- a/device_tree.h
> +++ b/device_tree.h
> @@ -18,7 +18,7 @@ void *create_device_tree(int *sizep);
>  void *load_device_tree(const char *filename_path, int *sizep);
>
>  int qemu_devtree_setprop(void *fdt, const char *node_path,
> -                         const char *property, void *val_array, int size);
> +                         const char *property, const void *val_array, int size);
>  int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
>                               const char *property, uint32_t val);
>  int qemu_devtree_setprop_u64(void *fdt, const char *node_path,
> --
> 1.6.0.2
>
>

Patch

diff --git a/device_tree.c b/device_tree.c
index acae53e..b366fdd 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -127,7 +127,7 @@  static int findnode_nofail(void *fdt, const char *node_path)
 }
 
 int qemu_devtree_setprop(void *fdt, const char *node_path,
-                         const char *property, void *val_array, int size)
+                         const char *property, const void *val_array, int size)
 {
     int r;
 
diff --git a/device_tree.h b/device_tree.h
index 4898d95..2244270 100644
--- a/device_tree.h
+++ b/device_tree.h
@@ -18,7 +18,7 @@  void *create_device_tree(int *sizep);
 void *load_device_tree(const char *filename_path, int *sizep);
 
 int qemu_devtree_setprop(void *fdt, const char *node_path,
-                         const char *property, void *val_array, int size);
+                         const char *property, const void *val_array, int size);
 int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
                               const char *property, uint32_t val);
 int qemu_devtree_setprop_u64(void *fdt, const char *node_path,