Patchwork [v2] ext4: change a comment on fs/ext4/extents.c

login
register
mail settings
Submitter Liu Haibo
Date June 21, 2012, 1:23 p.m.
Message ID <4fe32049.28d5440a.3265.ffffb61a@mx.google.com>
Download mbox | patch
Permalink /patch/166304/
State Accepted
Headers show

Comments

Liu Haibo - June 21, 2012, 1:23 p.m.
From: HaiboLiu <HaiboLiu6@gmail.com>

In this patch, ext4_ext_try_to_merge has been change to merge 
an extent both left and right. So we need to update the comment
in here.

v1->v2: update the subject and the patch comment.

Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>
---
 fs/ext4/extents.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Theodore Ts'o - July 9, 2012, 2:21 p.m.
On Thu, Jun 21, 2012 at 03:23:14AM -0000, Liu Haibo wrote:
> From: HaiboLiu <HaiboLiu6@gmail.com>
> 
> In this patch, ext4_ext_try_to_merge has been change to merge 
> an extent both left and right. So we need to update the comment
> in here.
> 
> v1->v2: update the subject and the patch comment.
> 
> Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>

Applied, thanks.

BTW, in the future, it's better to put the v1-v2 log after the "---"
separator.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 74f23c2..db671b9 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1807,11 +1807,10 @@  has_space:
 	nearex->ee_len = newext->ee_len;
 
 merge:
-	/* try to merge extents to the right */
+	/* try to merge extents */
 	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
 		ext4_ext_try_to_merge(inode, path, nearex);
 
-	/* try to merge extents to the left */
 
 	/* time to correct all indexes above */
 	err = ext4_ext_correct_indexes(handle, inode, path);