From patchwork Thu Jun 21 07:04:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: rtc/r9701: avoid second call to the rtc_valid_tm From: Devendra Naga X-Patchwork-Id: 166237 Message-Id: <1340262280-15096-1-git-send-email-devendra.aaru@gmail.com> To: Alessandro Zummo , Andrew Morton , Anatolij Gustschin , Andreas Dumberger , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Cc: Devendra Naga Date: Thu, 21 Jun 2012 12:34:40 +0530 r9701_get_datetime will call the rtc_valid_tm and it returns the value returned by rtc_valid_tm, which anyway can be used in the if so calling rtc_valid_tm is not required. Signed-off-by: Devendra Naga --- This change is compiled tested only using gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 on x86_64 (intel core i3). drivers/rtc/rtc-r9701.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-r9701.c b/drivers/rtc/rtc-r9701.c index 33b6ba0..e6c34c0 100644 --- a/drivers/rtc/rtc-r9701.c +++ b/drivers/rtc/rtc-r9701.c @@ -138,8 +138,7 @@ static int __devinit r9701_probe(struct spi_device *spi) * contain invalid values. If so, try to write a default date: * 2000/1/1 00:00:00 */ - r9701_get_datetime(&spi->dev, &dt); - if (rtc_valid_tm(&dt)) { + if (r9701_get_datetime(&spi->dev, &dt)) { dev_info(&spi->dev, "trying to repair invalid date/time\n"); dt.tm_sec = 0; dt.tm_min = 0;