Patchwork [3/3] UBI: is_mapped operation via ioctl

login
register
mail settings
Submitter Corentin Chary
Date Jan. 5, 2009, 2:07 p.m.
Message ID <71cd59b00901050607l4356c850y2be8ea93d8437fbd@mail.gmail.com>
Download mbox | patch
Permalink /patch/16620/
State New
Headers show

Comments

Corentin Chary - Jan. 5, 2009, 2:07 p.m.
From: Corentin Chary <corentincj@iksaif.net>

UBI: is_mapped operation via ioctl

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/mtd/ubi/cdev.c |   12 ++++++++++++
 include/mtd/ubi-user.h |    2 ++
 2 files changed, 14 insertions(+), 0 deletions(-)
Artem Bityutskiy - Jan. 5, 2009, 2:33 p.m.
On Mon, 2009-01-05 at 15:07 +0100, Corentin Chary wrote:
> diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
> index bcff3a0..a65c4ab 100644
> --- a/include/mtd/ubi-user.h
> +++ b/include/mtd/ubi-user.h
> @@ -137,6 +137,8 @@
>  #define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
>  /* Unmap an eraseblock */
>  #define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
> +/* check whether an eraseblock is mapped */
Bettert to start from capital "C".

> +#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)
I think this should be _IOR instead.

_IOR: data is transferred from kernel to user-space
_IOW: data is transferred from user-space to kernel
_IORW: both directions

Otherwise, the patches look OK for me.
Corentin Chary - Jan. 6, 2009, 9:25 a.m.
> Otherwise, the patches look OK for me.
Do you want me to send the corrected patch or is it ok ?
Artem Bityutskiy - Jan. 6, 2009, 11:58 a.m.
On Tue, 2009-01-06 at 10:25 +0100, Corentin Chary wrote:
> > Otherwise, the patches look OK for me.
> Do you want me to send the corrected patch or is it ok ?

No, thanks, I think I can tweak your patch myself a bit later.

Patch

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 7a9080c..1bf21eb 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -542,6 +542,18 @@  static int vol_cdev_ioctl(struct inode *inode,
struct file *file,
 		err = ubi_leb_unmap(desc, lnum);
 		break;
 	}
+	case UBI_IOISMAP:
+	{
+		int32_t lnum;
+
+		err = get_user(lnum, (__user int32_t *)argp);
+		if (err) {
+			err = -EFAULT;
+			break;
+		}
+		err = ubi_is_mapped(desc, lnum);
+		break;
+	}

 #endif

diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
index bcff3a0..a65c4ab 100644
--- a/include/mtd/ubi-user.h
+++ b/include/mtd/ubi-user.h
@@ -137,6 +137,8 @@ 
 #define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
 /* Unmap an eraseblock */
 #define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
+/* check whether an eraseblock is mapped */
+#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)

 /* Maximum MTD device name length supported by UBI */
 #define MAX_UBI_MTD_NAME_LEN 127