| Submitter | Tom Rini |
|---|---|
| Date | June 20, 2012, 10:14 p.m. |
| Message ID | <1340230468-12811-6-git-send-email-trini@ti.com> |
| Download | mbox | patch |
| Permalink | /patch/166157/ |
| State | Rejected |
| Delegated to: | Tom Rini |
| Headers | show |
Comments
Hi Tom, [snip..] > #define CONFIG_USB_HOST > #define CONFIG_USB_EHCI > #define CONFIG_USB_EHCI_OMAP > +#define CONFIG_SYS_DCACHE_OFF /* USB_EHCI is unusable with DCACHE > support */ > #define CONFIG_USB_STORAGE > #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 While, this looks like to be the safest option till we fix both the cache issue and alignment issue in USB stack. Thanks, Sricharan
Hi, On Thu, Jun 21, 2012 at 4:49 PM, Sricharan R <r.sricharan@ti.com> wrote: > Hi Tom, > [snip..] >> #define CONFIG_USB_HOST >> #define CONFIG_USB_EHCI >> #define CONFIG_USB_EHCI_OMAP >> +#define CONFIG_SYS_DCACHE_OFF /* USB_EHCI is unusable with > DCACHE >> support */ >> #define CONFIG_USB_STORAGE >> #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 > > While, this looks like to be the safest option till > we fix both the cache issue and alignment issue in USB stack. > Acked-by: R Sricharan <r.sricharan@ti.com> Thanks, Sricharan
Patch
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index b4756be..468cf7a 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -38,6 +38,7 @@ #define CONFIG_USB_HOST #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_OMAP +#define CONFIG_SYS_DCACHE_OFF /* USB_EHCI is unusable with DCACHE support */ #define CONFIG_USB_STORAGE #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
USB EHCI and DCACHE are not compatible, so disable DCACHE support at build-time as run-time disable is insufficient for USB use. Cc: Sricharan R <r.sricharan@ti.com> Signed-off-by: Tom Rini <trini@ti.com> --- include/configs/omap4_panda.h | 1 + 1 file changed, 1 insertion(+)