Patchwork add DECL_SOURCE_COLUMN to tree.h (trivial)

login
register
mail settings
Submitter Rüdiger Sonderfeld
Date June 20, 2012, 5:43 p.m.
Message ID <41884458.ESJsE0SEy4@descartes>
Download mbox | patch
Permalink /patch/166128/
State New
Headers show

Comments

Rüdiger Sonderfeld - June 20, 2012, 5:43 p.m.
Hello,
I'm currently writing a plugin for GCC and I need to extract the column of a 
declaration. There exists DECL_SOURCE_FILE/LINE already and for consistency 
reasons and ease of use I've added a DECL_SOURCE_COLUMN macro.

The patch is extremely trivial and probably doesn't need copyright assignment. 
However I have signed copyright assignment for Emacs and maybe that will work 
too (not sure if this has to be signed for every project).

gcc/ChangeLog

2012-06-20  Rüdiger Sonderfeld  <ruediger@c-plusplus.de>

	* tree.h (DECL_SOURCE_COLUMN): New accessor

Regards,
Rüdiger
Diego Novillo - June 20, 2012, 5:50 p.m.
On 12-06-20 13:43 , Rüdiger Sonderfeld wrote:

> The patch is extremely trivial and probably doesn't need copyright assignment.
> However I have signed copyright assignment for Emacs and maybe that will work
> too (not sure if this has to be signed for every project).

It does, unfortunately.

>
> gcc/ChangeLog
>
> 2012-06-20  Rüdiger Sonderfeld  <ruediger@c-plusplus.de>
>
> 	* tree.h (DECL_SOURCE_COLUMN): New accessor

OK.  I suppose you do not have write to the repo, so I will commit it 
for you.


Diego.
Diego Novillo - June 20, 2012, 6:03 p.m.
On 12-06-20 13:50 , Diego Novillo wrote:

> OK.  I suppose you do not have write to the repo, so I will commit it
> for you.

Committed r188841.


Diego.

Patch

Index: gcc/tree.h
===================================================================
--- gcc/tree.h	(revision 188837)
+++ gcc/tree.h	(working copy)
@@ -2670,6 +2670,7 @@ 
   (DECL_MINIMAL_CHECK (NODE)->decl_minimal.locus)
 #define DECL_SOURCE_FILE(NODE) LOCATION_FILE (DECL_SOURCE_LOCATION (NODE))
 #define DECL_SOURCE_LINE(NODE) LOCATION_LINE (DECL_SOURCE_LOCATION (NODE))
+#define DECL_SOURCE_COLUMN(NODE) LOCATION_COLUMN (DECL_SOURCE_LOCATION (NODE))
 #define DECL_IS_BUILTIN(DECL) \
   (DECL_SOURCE_LOCATION (DECL) <= BUILTINS_LOCATION)