From patchwork Wed Jun 20 17:11:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Drepper X-Patchwork-Id: 166126 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6748CB6EE6 for ; Thu, 21 Jun 2012 03:11:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755420Ab2FTRLs (ORCPT ); Wed, 20 Jun 2012 13:11:48 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:64643 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754265Ab2FTRLr (ORCPT ); Wed, 20 Jun 2012 13:11:47 -0400 Received: by qcro28 with SMTP id o28so4331948qcr.19 for ; Wed, 20 Jun 2012 10:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=dhazQSxzT2v/t/5n6o5/sgeeC4HSJikp5jEXrtKkyLY=; b=HVN3zJACg/ZErb2H/Jg1BQtxHS3TOPDC68gOcu16BIZG22dAW9IgBNVdyRtAEoJymn F614bnaIaC2P9fhzE1jf0oTgWyZNf1flnqAiWb8vxbyCs6lHf6wN8rZcjXR/5LDUrAyl 0XO5v+d+i1iZf9K6JHZpI4Os9MlMQb2SNTVWwU0jGBhnT1siQlktcOZCmvVQtO9gFf2e nQ7tf7AdnbVjI8UYaid7ZmBI+slm4vtE4LXyDpQDQoMmRWEsu5fDrwt2HIMwZ6k9quEA NBoOh5UN5ellB2M8JlTJKbZRrvYCMeYsXc+BCWaKLkl9R4rSiIi96Sta147fp2w/XdT2 +Vrg== Received: by 10.229.135.206 with SMTP id o14mr12437218qct.148.1340212306381; Wed, 20 Jun 2012 10:11:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.32.9 with HTTP; Wed, 20 Jun 2012 10:11:26 -0700 (PDT) In-Reply-To: References: From: Ulrich Drepper Date: Wed, 20 Jun 2012 13:11:26 -0400 Message-ID: Subject: Re: SNB PCI root information To: Yinghai Lu Cc: Bjorn Helgaas , jbarnes@virtuousgeek.org, Linux Kernel Mailing List , lenb@kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jun 19, 2012 at 2:20 PM, Yinghai Lu wrote: > If the BIOS provide wrong _PXM, that BIOS really should be fixed at first. Let's go there when we see BIOSes with the information... In the meantime I tested the patch. It needs the small modification below (iinterdiff-generated). The problem is the pci= parameter handling uses ',' to separate parameters and therefore the second PCI root information, separated by a comma, is interpreted as a new pci= parameter. The patch below changes the separator to ';'. With that I get the correct information after boot up. Signed-off-by: Ulrich Drepper --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -u b/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt --- b/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -2192,7 +2192,7 @@ realloc same as realloc=on busnum_node= Format: - :[, ...] + :[;...] Specifies node for bus noari do not use PCIe ARI. pcie_scan_all Scan all possible PCIe devices. Otherwise we diff -u b/arch/x86/pci/common.c b/arch/x86/pci/common.c --- b/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -509,7 +509,7 @@ } set_mp_bus_to_node(bus, node); p += count; - if (*p != ',') + if (*p != ';') break; p++; }