Patchwork SNB PCI root information

login
register
mail settings
Submitter Ulrich Drepper
Date June 20, 2012, 5:11 p.m.
Message ID <CAOPLpQe+PE0NLuDuPZ1JuF+8ivr1Y+xF8dNN4y-DXV7endYtFg@mail.gmail.com>
Download mbox | patch
Permalink /patch/166126/
State Superseded
Headers show

Comments

Ulrich Drepper - June 20, 2012, 5:11 p.m.
On Tue, Jun 19, 2012 at 2:20 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> If the BIOS provide wrong _PXM, that BIOS really should be fixed at first.

Let's go there when we see BIOSes with the information...

In the meantime I tested the patch.  It needs the small modification
below (iinterdiff-generated).  The problem is the pci= parameter
handling uses ',' to separate parameters and therefore the second PCI
root information, separated by a comma, is interpreted as a new pci=
parameter.  The patch below changes the separator to ';'.  With that I
get the correct information after boot up.


Signed-off-by: Ulrich Drepper <drepper@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -u b/Documentation/kernel-parameters.txt
b/Documentation/kernel-parameters.txt
--- b/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -2192,7 +2192,7 @@ 
 		realloc		same as realloc=on
 		busnum_node=
 				Format:
-				<bus>:<node>[, ...]
+				<bus>:<node>[;...]
 				Specifies node for bus
 		noari		do not use PCIe ARI.
 		pcie_scan_all	Scan all possible PCIe devices.  Otherwise we
diff -u b/arch/x86/pci/common.c b/arch/x86/pci/common.c
--- b/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -509,7 +509,7 @@ 
 		}
 		set_mp_bus_to_node(bus, node);
 		p += count;
-		if (*p != ',')
+		if (*p != ';')
 			break;
 		p++;
 	}