Patchwork tci: Support INDEX_op_bswap64_i64

login
register
mail settings
Submitter Stefan Weil
Date June 20, 2012, 4:07 p.m.
Message ID <1340208444-14440-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/166116/
State Accepted
Headers show

Comments

Stefan Weil - June 20, 2012, 4:07 p.m.
Running the Windows 7 (64 bit) boot process needs INDEX_op_bswap64_i64.
It was already implemented, but untested. Remove the TODO() statement.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 tci.c |    1 -
 1 file changed, 1 deletion(-)
Stefan Hajnoczi - June 22, 2012, 9:09 a.m.
On Wed, Jun 20, 2012 at 06:07:24PM +0200, Stefan Weil wrote:
> Running the Windows 7 (64 bit) boot process needs INDEX_op_bswap64_i64.
> It was already implemented, but untested. Remove the TODO() statement.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  tci.c |    1 -
>  1 file changed, 1 deletion(-)

If you weren't TCI maintainer I would ask for this patch to go through
your tree because I don't touch TCG and this is declaring an operation
supported, which the maintainer needs to be okay with.  Anyway, this is
fine since it's coming from you.

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/tci.c b/tci.c
index e40c080..01d365a 100644
--- a/tci.c
+++ b/tci.c
@@ -1036,7 +1036,6 @@  tcg_target_ulong tcg_qemu_tb_exec(CPUArchState *cpustate, uint8_t *tb_ptr)
 #endif
 #if TCG_TARGET_HAS_bswap64_i64
         case INDEX_op_bswap64_i64:
-            TODO();
             t0 = *tb_ptr++;
             t1 = tci_read_r64(&tb_ptr);
             tci_write_reg64(t0, bswap64(t1));