From patchwork Wed Jun 20 13:37:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 166074 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B317CB6FCA for ; Wed, 20 Jun 2012 23:37:58 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340804279; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:Cc:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=ih3i6WDeBmoeJscjtkDsYs/pbhY=; b=eGzKkrv7Nl/yh4w9PLAAk8mU2zQfpJc30yyL66PBpjy4Duhbo74rdpe//FDbh9 HGqdyXmjMawMz8ol7eXAoB5ifOmTYEK43ogitwaS9QYECkmcXopDsYjOfDrFmiAq 9HqXSPHYkNeUkORV0DduYP4SK67AByCOs3j1Y0iCaIfFw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Cc:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=RdQukHeDnGVU/TFU6zPS/GlZBNIrDywSoGHjrxLbn3lq7AIB59v+Via98Q0n4Z uK4+gM/ksXbWJAuvs6MvEtvQlQ/AKDl0bZI1lag8r2fc3NcKxSEtEYbgNUeoEscl rEBbldBmh4vsdJ/kfdEOFHJTXiR0dfwFXoiEitgteXm98=; Received: (qmail 864 invoked by alias); 20 Jun 2012 13:37:53 -0000 Received: (qmail 764 invoked by uid 22791); 20 Jun 2012 13:37:52 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from eu1sys200aog111.obsmtp.com (HELO eu1sys200aog111.obsmtp.com) (207.126.144.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 13:37:22 +0000 Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob111.postini.com ([207.126.147.11]) with SMTP ID DSNKT+HSDlAxey44OTJp5VXYp8nOF4AVqtai@postini.com; Wed, 20 Jun 2012 13:37:20 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DCCD5105; Wed, 20 Jun 2012 13:37:03 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 741B54883; Wed, 20 Jun 2012 13:37:03 +0000 (GMT) Received: from [164.129.122.162] (164.129.122.162) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.192.1; Wed, 20 Jun 2012 15:37:03 +0200 Message-ID: <4FE1D1FE.9040204@st.com> Date: Wed, 20 Jun 2012 15:37:02 +0200 From: Christophe Lyon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ramana Radhakrishnan Cc: gcc-patches Subject: Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin References: <4FAA445A.8080605@st.com> <4FABDF5F.6070105@st.com> <4FB3B0CA.1090605@st.com> <4FBA07DF.6070801@st.com> <4FBF9BC6.4000809@st.com> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 06.06.2012 11:00, Ramana Radhakrishnan wrote: > Ok with those changes. Ramana . Hi Ramana, How about this version? Christophe. commit f57ce4b63ca1c30ee88e8c1a431d6e90ffbecb82 Author: Christophe Lyon Date: Wed Jun 20 15:30:50 2012 +0200 2012-06-20 Christophe Lyon * gcc/config/arm/neon.md (UNSPEC_VLD1_DUP): Remove. (neon_vld1_dup): Restrict to VQ operands. (neon_vld1_dupv2di): New, fixes vld1q_dup_s64. * gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c: New test. diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 4568dea..b3b925c 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -45,7 +45,6 @@ UNSPEC_VHADD UNSPEC_VHSUB UNSPEC_VLD1 - UNSPEC_VLD1_DUP UNSPEC_VLD1_LANE UNSPEC_VLD2 UNSPEC_VLD2_DUP @@ -4381,8 +4380,7 @@ (define_insn "neon_vld1_dup" [(set (match_operand:VDX 0 "s_register_operand" "=w") - (unspec:VDX [(match_operand: 1 "neon_struct_operand" "Um")] - UNSPEC_VLD1_DUP))] + (vec_duplicate:VDX (match_operand: 1 "neon_struct_operand" "Um")))] "TARGET_NEON" { if (GET_MODE_NUNITS (mode) > 1) @@ -4397,20 +4395,30 @@ ) (define_insn "neon_vld1_dup" - [(set (match_operand:VQX 0 "s_register_operand" "=w") - (unspec:VQX [(match_operand: 1 "neon_struct_operand" "Um")] - UNSPEC_VLD1_DUP))] + [(set (match_operand:VQ 0 "s_register_operand" "=w") + (vec_duplicate:VQ (match_operand: 1 "neon_struct_operand" "Um")))] "TARGET_NEON" { - if (GET_MODE_NUNITS (mode) > 2) - return "vld1.\t{%e0[], %f0[]}, %A1"; - else - return "vld1.\t%h0, %A1"; + return "vld1.\t{%e0[], %f0[]}, %A1"; } - [(set (attr "neon_type") - (if_then_else (gt (const_string "") (const_string "1")) - (const_string "neon_vld2_2_regs_vld1_vld2_all_lanes") - (const_string "neon_vld1_1_2_regs")))] + [(set_attr "neon_type" "neon_vld2_2_regs_vld1_vld2_all_lanes")] +) + +(define_insn_and_split "neon_vld1_dupv2di" + [(set (match_operand:V2DI 0 "s_register_operand" "=w") + (vec_duplicate:V2DI (match_operand:DI 1 "neon_struct_operand" "Um")))] + "TARGET_NEON" + "#" + "&& reload_completed" + [(const_int 0)] + { + rtx tmprtx = gen_lowpart (DImode, operands[0]); + emit_insn (gen_neon_vld1_dupdi (tmprtx, operands[1])); + emit_move_insn (gen_highpart (DImode, operands[0]), tmprtx ); + DONE; + } + [(set_attr "length" "8") + (set_attr "neon_type" "neon_vld2_2_regs_vld1_vld2_all_lanes")] ) (define_expand "vec_store_lanes" diff --git a/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c b/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c new file mode 100644 index 0000000..b5793bf --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c @@ -0,0 +1,24 @@ +/* Test the `vld1q_s64' ARM Neon intrinsic. */ + +/* { dg-do run } */ +/* { dg-require-effective-target arm_neon_hw } */ +/* { dg-options "-O0" } */ +/* { dg-add-options arm_neon } */ + +#include "arm_neon.h" +#include + +int main (void) +{ + int64x1_t input[2] = {(int64x1_t)0x0123456776543210LL, + (int64x1_t)0x89abcdeffedcba90LL}; + int64x1_t output[2] = {0, 0}; + int64x2_t var = vld1q_dup_s64(input); + + vst1q_s64(output, var); + if (output[0] != (int64x1_t)0x0123456776543210LL) + abort(); + if (output[1] != (int64x1_t)0x0123456776543210LL) + abort(); + return 0; +}