Patchwork RFA: PATCH to Makefile.def/tpl to add libgomp to make check-c++

login
register
mail settings
Submitter Jason Merrill
Date June 20, 2012, 7:26 a.m.
Message ID <4FE17B30.8050209@redhat.com>
Download mbox | patch
Permalink /patch/165906/
State New
Headers show

Comments

Jason Merrill - June 20, 2012, 7:26 a.m.
The recent regression in libgomp leads me to want to add libgomp tests 
to the check-c++ target.  OK for trunk?
Richard Guenther - June 20, 2012, 9:03 a.m.
On Wed, Jun 20, 2012 at 9:26 AM, Jason Merrill <jason@redhat.com> wrote:
> The recent regression in libgomp leads me to want to add libgomp tests to
> the check-c++ target.  OK for trunk?

Ok.  (what about libitm?)

Thanks,
Richard.
Mike Stump - June 21, 2012, 5:53 a.m.
On Jun 20, 2012, at 12:26 AM, Jason Merrill <jason@redhat.com> wrote:
> The recent regression in libgomp leads me to want to add libgomp tests to the check-c++ target.

I'm fine with the idea...

Patch

commit 3eaa6c5b268115cbf4ab762b5d7b50022389ef25
Author: Jason Merrill <jason@redhat.com>
Date:   Tue Jun 19 18:16:34 2012 -0700

    	* Makefile.tpl (check-target-libgomp-c++): New.
    	* Makefile.def (c++): Add it.
    	* Makefile.in: Regenerate.

diff --git a/Makefile.def b/Makefile.def
index 1449a50..2a0b8fa 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -518,7 +518,8 @@  dependencies = { module=configure-target-libgfortran; on=all-target-libquadmath;
 languages = { language=c;	gcc-check-target=check-gcc; };
 languages = { language=c++;	gcc-check-target=check-c++;
 				lib-check-target=check-target-libstdc++-v3;
-				lib-check-target=check-target-libmudflap-c++; };
+				lib-check-target=check-target-libmudflap-c++;
+				lib-check-target=check-target-libgomp-c++; };
 languages = { language=fortran;	gcc-check-target=check-fortran;
 				lib-check-target=check-target-libquadmath;
 				lib-check-target=check-target-libgfortran; };
diff --git a/Makefile.in b/Makefile.in
index def860e..9cf3543 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -41116,6 +41116,13 @@  check-target-libmudflap-c++:
 
 @endif target-libmudflap
 
+@if target-libgomp
+.PHONY: check-target-libgomp-c++
+check-target-libgomp-c++:
+	$(MAKE) RUNTESTFLAGS="$(RUNTESTFLAGS) c++.exp" check-target-libgomp
+
+@endif target-libgomp
+
 # ----------
 # GCC module
 # ----------
@@ -41150,7 +41157,7 @@  check-gcc-c++:
 	s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
 	$(HOST_EXPORTS) \
 	(cd gcc && $(MAKE) $(GCC_FLAGS_TO_PASS) check-c++);
-check-c++: check-gcc-c++ check-target-libstdc++-v3 check-target-libmudflap-c++
+check-c++: check-gcc-c++ check-target-libstdc++-v3 check-target-libmudflap-c++ check-target-libgomp-c++
 
 .PHONY: check-gcc-fortran check-fortran
 check-gcc-fortran:
diff --git a/Makefile.tpl b/Makefile.tpl
index 371c3b6..f06a7ce 100644
--- a/Makefile.tpl
+++ b/Makefile.tpl
@@ -1415,6 +1415,13 @@  check-target-libmudflap-c++:
 
 @endif target-libmudflap
 
+@if target-libgomp
+.PHONY: check-target-libgomp-c++
+check-target-libgomp-c++:
+	$(MAKE) RUNTESTFLAGS="$(RUNTESTFLAGS) c++.exp" check-target-libgomp
+
+@endif target-libgomp
+
 # ----------
 # GCC module
 # ----------