From patchwork Wed Jun 20 07:08:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 165897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id CB9D8B6FA1 for ; Wed, 20 Jun 2012 17:09:29 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340780971; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:From:Date: Message-ID:Subject:To:Cc:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=qfYRL8nUbPARTOUg2YqR EvT4xbw=; b=wrjXx6NocL/b+PRukSZqOs4xLwGvzf3HR5iCkfpNwY5AoRrrTfE5 h7Y0kf4qsRRgorW7/WauBNEvQYThd9/AUIwuP3ug+CrNuFMQBfiaAHIyUpjL2R46 lVCcIU3QeP9FczEzoOxSi8LTO3mAljhKm4u7tXnAviALTx3Fvg9oCmM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:In-Reply-To:References:From:Date:Message-ID:Subject:To:Cc:Content-Type:Content-Transfer-Encoding:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=gxjvTDOEwRz6TQXtLQR1K3faLsm/jT0Xlgn6a25qVFvcsCvmC1m7pZl4gQ/adp IakK2cqcnu9cehgutZPb8cQBTEzM6g2vnM6hUbUZ/LqRaKAZ9S1wUJN3+8JlirOf P7pCr+wycHGwThnAieQx3mHZ4fMum1rKi9v66vzVbXzOo=; Received: (qmail 6113 invoked by alias); 20 Jun 2012 07:09:24 -0000 Received: (qmail 6101 invoked by uid 22791); 20 Jun 2012 07:09:23 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 07:09:10 +0000 Received: by lbol5 with SMTP id l5so201134lbo.20 for ; Wed, 20 Jun 2012 00:09:08 -0700 (PDT) Received: by 10.112.88.34 with SMTP id bd2mr8914646lbb.33.1340176148540; Wed, 20 Jun 2012 00:09:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.4.229 with HTTP; Wed, 20 Jun 2012 00:08:48 -0700 (PDT) In-Reply-To: References: From: Steven Bosscher Date: Wed, 20 Jun 2012 09:08:48 +0200 Message-ID: Subject: Re: [patch] Deal with #ident without To: Hans-Peter Nilsson Cc: GCC Patches X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Jun 20, 2012 at 2:21 AM, Hans-Peter Nilsson wrote: > On Tue, 19 Jun 2012, Steven Bosscher wrote: >> I've now committed this, see r188791. > > Breaking cris-elf.  Just try rebuilding cc1: > ...../gcc/gcc/../libdecnumber/dpd -I../libdecnumber    \ >                /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c -o cris.o > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c: In function 'cris_asm_output_ident': > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2480: error: 'cgraph_state' undeclared (first use in this function) > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2480: error: (Each undeclared identifier is reported only once > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2480: error: for each function it appears in.) > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2480: error: 'CGRAPH_STATE_PARSING' undeclared (first use in this funct\ > ion) > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2478: warning: unused variable 'buf' > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2477: warning: unused variable 'size' > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2476: warning: unused variable 'section_asm_op' > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c: In function 'cris_option_override': > /tmp/hpautotest-gcc1/gcc/gcc/config/cris/cris.c:2538: error: 'flag_no_gcc_ident' undeclared (first use in this function\ > ) > make[2]: *** [cris.o] Error 1 Grr. A merge f*ck-up. This was in my testing tree on the compile farm but not in the patch I committed: I'm building a cross to cris-elf now, to be sure, and I'll commit this ASAP after that. Sorry for this... Ciao! Steven Index: config/cris/cris.c =================================================================== --- config/cris/cris.c (revision 188808) +++ config/cris/cris.c (working copy) @@ -47,6 +47,7 @@ along with GCC; see the file COPYING3. #include "optabs.h" #include "df.h" #include "opts.h" +#include "cgraph.h" /* Usable when we have an amount to add or subtract, and want the optimal size of the insn. */ @@ -2533,10 +2534,6 @@ cris_asm_output_case_end (FILE *stream, static void cris_option_override (void) { - /* We don't want an .ident for gcc. - It isn't really clear anymore why not. */ - flag_no_gcc_ident = true; - if (cris_max_stackframe_str) { cris_max_stackframe = atoi (cris_max_stackframe_str);