Patchwork change a comment on fs/ext4/extents.c

login
register
mail settings
Submitter Liu Haibo
Date June 19, 2012, 3:35 p.m.
Message ID <4fe09c5f.4ad3440a.5cc5.7bac@mx.google.com>
Download mbox | patch
Permalink /patch/165778/
State Superseded
Headers show

Comments

Liu Haibo - June 19, 2012, 3:35 p.m.
From: HaiboLiu <HaiboLiu6@gmail.com>

May be it's better.

Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>
---
 fs/ext4/extents.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Zheng Liu - June 20, 2012, 3:51 p.m.
Hi Haibo,

If your patch only relates to ext4, please change the patch's subject
like this:
[PATCH] ext4: change a comment on fs/ext4/extents.c

On Tue, Jun 19, 2012 at 11:35:47PM +0800, haiboliu6@gmail.com wrote:
> From: HaiboLiu <HaiboLiu6@gmail.com>
> 
> May be it's better.

Maybe the following commit log is better:
In this patch (197217a5), ext4_ext_try_to_merge has been changed to
merge an extent both left and right.  So we need to update the comment
in here.

Regards,
Zheng

> 
> Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>
> ---
>  fs/ext4/extents.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 74f23c2..db671b9 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1807,11 +1807,10 @@ has_space:
>  	nearex->ee_len = newext->ee_len;
>  
>  merge:
> -	/* try to merge extents to the right */
> +	/* try to merge extents */
>  	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>  		ext4_ext_try_to_merge(inode, path, nearex);
>  
> -	/* try to merge extents to the left */
>  
>  	/* time to correct all indexes above */
>  	err = ext4_ext_correct_indexes(handle, inode, path);
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Liu Haibo - June 21, 2012, 6:14 p.m.
> Hi Haibo,
> 
> If your patch only relates to ext4, please change the patch's subject
> like this:
> [PATCH] ext4: change a comment on fs/ext4/extents.c
> 
> On Tue, Jun 19, 2012 at 11:35:47PM +0800, haiboliu6@gmail.com wrote:
> > From: HaiboLiu <HaiboLiu6@gmail.com>
> > 
> > May be it's better.
> 
> Maybe the following commit log is better:
> In this patch (197217a5), ext4_ext_try_to_merge has been changed to
> merge an extent both left and right.  So we need to update the comment
> in here.
> 
> Regards,
> Zheng
> 
> > 
> > Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>
> > ---
> >  fs/ext4/extents.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 74f23c2..db671b9 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -1807,11 +1807,10 @@ has_space:
> >  	nearex->ee_len = newext->ee_len;
> >  
> >  merge:
> > -	/* try to merge extents to the right */
> > +	/* try to merge extents */
> >  	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
> >  		ext4_ext_try_to_merge(inode, path, nearex);
> >  
> > -	/* try to merge extents to the left */
> >  
> >  	/* time to correct all indexes above */
> >  	err = ext4_ext_correct_indexes(handle, inode, path);
> > -- 
> > 1.7.9.5
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks for your suggestion. I update the patch subject and the patch comment and resend it.

Regards,
Haibo Liu
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 74f23c2..db671b9 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1807,11 +1807,10 @@  has_space:
 	nearex->ee_len = newext->ee_len;
 
 merge:
-	/* try to merge extents to the right */
+	/* try to merge extents */
 	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
 		ext4_ext_try_to_merge(inode, path, nearex);
 
-	/* try to merge extents to the left */
 
 	/* time to correct all indexes above */
 	err = ext4_ext_correct_indexes(handle, inode, path);