| Message ID | 4FDF2DBD.5090805@users.sourceforge.net |
|---|---|
| State | New |
| Headers | show |
2012/6/18 JonY <jon_y@users.sourceforge.net>: > Hi, > > I am told that this ABI test does not apply to mingw targets. OK to apply? Hi JonY, The test doesn't apply to x64 windows targets, as for it sse is part of its ABI. As test already checks for !ia32, we could simply check for x86_64/i?86-*-mingw* targets instead. We don't need to check for ilp32 here again. Regards, Kai
On Mon, Jun 18, 2012 at 10:09 AM, Kai Tietz <ktietz70@googlemail.com> wrote: > 2012/6/18 JonY <jon_y@users.sourceforge.net>: >> Hi, >> >> I am told that this ABI test does not apply to mingw targets. OK to apply? > > Hi JonY, > > The test doesn't apply to x64 windows targets, as for it sse is part of its ABI. > As test already checks for !ia32, we could simply check for > x86_64/i?86-*-mingw* targets instead. We don't need to check for > ilp32 here again. The test needs to be skipped if the target is: x86_64-*-mingw* i*86-*-mingw* with -m64 multilib option and it needs to run if the target is: i*86-*-mingw* x86_64-*-mingw* with -m32 multilib option Does anyone know how to make that happen?
As both tests are checking already for !ia32, there is no additiona check beside the targets necessary. Cheers, Kai
Index: gcc/testsuite/gcc.target/i386/pr53425-1.c =================================================================== --- gcc/testsuite/gcc.target/i386/pr53425-1.c (revision 188384) +++ gcc/testsuite/gcc.target/i386/pr53425-1.c (working copy) @@ -1,6 +1,7 @@ /* PR target/53425 */ /* { dg-do compile { target { ! { ia32 } } } } */ /* { dg-options "-O2 -mno-sse" } */ +/* { dg-skip-if "" { { i?86-*-mingw* x86_64-*-mingw* } && ! ilp32 } { "*" } { "" } } */ typedef double __v2df __attribute__ ((__vector_size__ (16))); Index: gcc/testsuite/gcc.target/i386/pr53425-2.c =================================================================== --- gcc/testsuite/gcc.target/i386/pr53425-2.c (revision 188384) +++ gcc/testsuite/gcc.target/i386/pr53425-2.c (working copy) @@ -1,6 +1,7 @@ /* PR target/53425 */ /* { dg-do compile { target { ! { ia32 } } } } */ /* { dg-options "-O2 -mno-sse" } */ +/* { dg-skip-if "" { { i?86-*-mingw* x86_64-*-mingw* } && ! ilp32 } { "*" } { "" } } */ typedef float __v2sf __attribute__ ((__vector_size__ (8)));