Patchwork [lucid,SRU,pull-request] bug #1004707 - drm/i915 : external VGA1 only mode causes screen flickering

login
register
mail settings
Submitter Chris J Arges
Date June 15, 2012, 5:26 p.m.
Message ID <4FDB703E.6000408@canonical.com>
Download mbox
Permalink /patch/165204/
State New
Headers show

Pull-request

ssh://kernel.ubuntu.com/srv/kernel.ubuntu.com/git/arges/ubuntu-lucid.git

Comments

Chris J Arges - June 15, 2012, 5:26 p.m.
On 06/15/2012 10:43 AM, Chris J Arges wrote:
> BugLink: https://bugs.launchpad.net/bugs/1004707
> 
> == Lucid SRU Justification ==
> 
>     Impact: On laptops with pineview graphics external monitor only mode
> can cause the output to flicker.
> 
> == Fix ==
> 
> Upstream commits:
> - 9553426372eef71c849499fb1d232f4b0577c0f9
> - d4294342fd4b94a3297867da00c1c5e929c28d4f
> 
> These fix the issue by adding in proper support to set the Pineview CxSR
> registers. On patch ensure the hooks are setup properly and this state
> isn't overwritten, and the other patch adds a table which contains
> proper memory latencies for DDR3 memory on Pineview.
> 
> == Testcase ==
> 
> 1) Connect external VGA monitor to laptop.
> 2) Set mode to external VGA only with its maximum resolution.
> 3) Use xrandr to rotate monitor a few times, and turn on and off.
> 4) Press a few keys on the keyboard, and the monitor will start flickering.
> 
> == Pull request ==

Fixed an issue with the git repo, please try pulling now:

The following changes since commit c55c53e4a160746a63dd3e29da00e0e8c034b10c:

  UBUNTU: Ubuntu-2.6.32-41.91 (2012-06-12 10:11:15 +0100)

are available in the git repository at:


ssh://kernel.ubuntu.com/srv/kernel.ubuntu.com/git/arges/ubuntu-lucid.git
lp1004707

for you to fetch changes up to d2c343a27948be5c2ab40929a022f0af8b5fcc12:

  drm/i915: Add CxSR support on Pineview DDR3 (2012-06-15 12:22:58 -0500)

----------------------------------------------------------------
Li Peng (1):
      drm/i915: Add CxSR support on Pineview DDR3

Zhao Yakui (1):
      drm/i915: Move Pineview CxSR and watermark code into update_wm hook.

 drivers/gpu/drm/i915/i915_dma.c      |    4 +
 drivers/gpu/drm/i915/i915_drv.h      |    2 +-
 drivers/gpu/drm/i915/i915_reg.h      |   13 ++
 drivers/gpu/drm/i915/intel_display.c |  219
+++++++++++++++++++---------------
 4 files changed, 138 insertions(+), 100 deletions(-)
Tim Gardner - June 15, 2012, 5:39 p.m.
Clean cherry-picks. Changes appear to be restricted to just Pineview.
Herton Ronaldo Krzesinski - June 15, 2012, 6:22 p.m.
Ack. FYI, I rebased and synced master->master-next and did an
startnewrelease, after this week lucid SRU, so needs fetching of
master-next again before applying.
Tim Gardner - June 15, 2012, 6:49 p.m.