Patchwork [RFC,26/36] block: live snapshot documentation tweaks

login
register
mail settings
Submitter Paolo Bonzini
Date June 15, 2012, 3:05 p.m.
Message ID <1339772759-31004-27-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/165194/
State New
Headers show

Comments

Paolo Bonzini - June 15, 2012, 3:05 p.m.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qapi-schema.json |    4 ++++
 1 file changed, 4 insertions(+)
Eric Blake - June 15, 2012, 9:14 p.m.
On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qapi-schema.json |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 2ee988b..250edf2 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1289,6 +1289,7 @@
>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> +#          If the block device has no medium inserted, DeviceHasNoMedium
>  #          If @device is busy, DeviceInUse will be returned
>  #          If @snapshot-file can't be created, OpenFileFailed
>  #          If @snapshot-file can't be opened, OpenFileFailed

Can we combine these?

If @snapshot-file can't be opened or created, OpenFileFailed

> @@ -1321,6 +1322,9 @@
>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> +#          If the block device has no medium inserted, DeviceHasNoMedium
> +#          If @device is busy, DeviceInUse will be returned
> +#          If @snapshot-file can't be created, OpenFileFailed
>  #          If @snapshot-file can't be opened, OpenFileFailed

and again.
Paolo Bonzini - July 11, 2012, 4:16 p.m.
Il 15/06/2012 23:14, Eric Blake ha scritto:
> On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  qapi-schema.json |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 2ee988b..250edf2 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -1289,6 +1289,7 @@
>>  #
>>  # Returns: nothing on success
>>  #          If @device is not a valid block device, DeviceNotFound
>> +#          If the block device has no medium inserted, DeviceHasNoMedium
>>  #          If @device is busy, DeviceInUse will be returned
>>  #          If @snapshot-file can't be created, OpenFileFailed
>>  #          If @snapshot-file can't be opened, OpenFileFailed
> 
> Can we combine these?
> 
> If @snapshot-file can't be opened or created, OpenFileFailed
> 
>> @@ -1321,6 +1322,9 @@
>>  #
>>  # Returns: nothing on success
>>  #          If @device is not a valid block device, DeviceNotFound
>> +#          If the block device has no medium inserted, DeviceHasNoMedium
>> +#          If @device is busy, DeviceInUse will be returned
>> +#          If @snapshot-file can't be created, OpenFileFailed
>>  #          If @snapshot-file can't be opened, OpenFileFailed
> 
> and again.
> 

Yes, done.

Paolo

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 2ee988b..250edf2 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1289,6 +1289,7 @@ 
 #
 # Returns: nothing on success
 #          If @device is not a valid block device, DeviceNotFound
+#          If the block device has no medium inserted, DeviceHasNoMedium
 #          If @device is busy, DeviceInUse will be returned
 #          If @snapshot-file can't be created, OpenFileFailed
 #          If @snapshot-file can't be opened, OpenFileFailed
@@ -1321,6 +1322,9 @@ 
 #
 # Returns: nothing on success
 #          If @device is not a valid block device, DeviceNotFound
+#          If the block device has no medium inserted, DeviceHasNoMedium
+#          If @device is busy, DeviceInUse will be returned
+#          If @snapshot-file can't be created, OpenFileFailed
 #          If @snapshot-file can't be opened, OpenFileFailed
 #          If @format is invalid, InvalidBlockFormat
 #