Patchwork [lucid,SRU,pull-request] bug #1004707 - drm/i915 : external VGA1 only mode causes screen flickering

login
register
mail settings
Submitter Chris J Arges
Date June 15, 2012, 3:43 p.m.
Message ID <4FDB583D.9060806@canonical.com>
Download mbox
Permalink /patch/165162/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/srv/kernel.ubuntu.com/git/arges/ubuntu-lucid.git

Comments

Chris J Arges - June 15, 2012, 3:43 p.m.
BugLink: https://bugs.launchpad.net/bugs/1004707

== Lucid SRU Justification ==

    Impact: On laptops with pineview graphics external monitor only mode
can cause the output to flicker.

== Fix ==

Upstream commits:
- 9553426372eef71c849499fb1d232f4b0577c0f9
- d4294342fd4b94a3297867da00c1c5e929c28d4f

These fix the issue by adding in proper support to set the Pineview CxSR
registers. On patch ensure the hooks are setup properly and this state
isn't overwritten, and the other patch adds a table which contains
proper memory latencies for DDR3 memory on Pineview.

== Testcase ==

1) Connect external VGA monitor to laptop.
2) Set mode to external VGA only with its maximum resolution.
3) Use xrandr to rotate monitor a few times, and turn on and off.
4) Press a few keys on the keyboard, and the monitor will start flickering.

== Pull request ==

The following changes since commit 6196a0c82f84c643ef6d2c168b76cdbca49a8739:

  UBUNTU: Ubuntu-2.6.32-41.89 (2012-04-27 18:00:37 -0300)

are available in the git repository at:

  git://kernel.ubuntu.com/srv/kernel.ubuntu.com/git/arges/ubuntu-lucid.git

for you to fetch changes up to c761d2884e1f594cdd68b13a4592a3521d5e8205:

  drm/i915: Add CxSR support on Pineview DDR3 (2012-06-14 15:38:49 -0500)

----------------------------------------------------------------
Li Peng (1):
      drm/i915: Add CxSR support on Pineview DDR3

Zhao Yakui (1):
      drm/i915: Move Pineview CxSR and watermark code into update_wm hook.

 drivers/gpu/drm/i915/i915_dma.c | 4 +
 drivers/gpu/drm/i915/i915_drv.h | 2 +-
 drivers/gpu/drm/i915/i915_reg.h | 13 ++
 drivers/gpu/drm/i915/intel_display.c | 219
+++++++++++++++++++---------------
 4 files changed, 138 insertions(+), 100 deletions(-)
Tim Gardner - June 15, 2012, 4:25 p.m.
On 06/15/2012 09:43 AM, Chris J Arges wrote:
> BugLink: https://bugs.launchpad.net/bugs/1004707
> 
> == Lucid SRU Justification ==
> 
>     Impact: On laptops with pineview graphics external monitor only mode
> can cause the output to flicker.
> 
> == Fix ==
> 
> Upstream commits:
> - 9553426372eef71c849499fb1d232f4b0577c0f9
> - d4294342fd4b94a3297867da00c1c5e929c28d4f
> 
> These fix the issue by adding in proper support to set the Pineview CxSR
> registers. On patch ensure the hooks are setup properly and this state
> isn't overwritten, and the other patch adds a table which contains
> proper memory latencies for DDR3 memory on Pineview.
> 
> == Testcase ==
> 
> 1) Connect external VGA monitor to laptop.
> 2) Set mode to external VGA only with its maximum resolution.
> 3) Use xrandr to rotate monitor a few times, and turn on and off.
> 4) Press a few keys on the keyboard, and the monitor will start flickering.
> 
> == Pull request ==
> 
> The following changes since commit 6196a0c82f84c643ef6d2c168b76cdbca49a8739:
> 
>   UBUNTU: Ubuntu-2.6.32-41.89 (2012-04-27 18:00:37 -0300)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/srv/kernel.ubuntu.com/git/arges/ubuntu-lucid.git
> 
> for you to fetch changes up to c761d2884e1f594cdd68b13a4592a3521d5e8205:
> 
>   drm/i915: Add CxSR support on Pineview DDR3 (2012-06-14 15:38:49 -0500)
> 
> ----------------------------------------------------------------
> Li Peng (1):
>       drm/i915: Add CxSR support on Pineview DDR3
> 
> Zhao Yakui (1):
>       drm/i915: Move Pineview CxSR and watermark code into update_wm hook.
> 
>  drivers/gpu/drm/i915/i915_dma.c | 4 +
>  drivers/gpu/drm/i915/i915_drv.h | 2 +-
>  drivers/gpu/drm/i915/i915_reg.h | 13 ++
>  drivers/gpu/drm/i915/intel_display.c | 219
> +++++++++++++++++++---------------
>  4 files changed, 138 insertions(+), 100 deletions(-)
> 

Your pull request isn't quite correct. The path is mangled, plus you
didn't include the branch.

git request-pull Ubuntu-2.6.32-41.89
git://kernel.ubuntu.com/arges/ubuntu-lucid.git lp1004707

After cloning your repo and having a look at the branch lp1004707 it
appears you've got an extra commit 'UBUNTU: SAUCE: FIXME: Fix up missing
symbol.' that isn't showing up in the pull request summary. Please
confirm and resubmit with a correct pull request.

rtg