Patchwork 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

login
register
mail settings
Submitter Kamalesh Babulal
Date Jan. 4, 2009, 6:24 p.m.
Message ID <20090104182441.GA5086@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/16511/
State Superseded, archived
Headers show

Comments

Kamalesh Babulal - Jan. 4, 2009, 6:24 p.m.
* Milton Miller <miltonm@bga.com> [2009-01-04 02:54:15]:

> In-Reply-To: <20090103191359.GA9304@linux.vnet.ibm.com>
>
> Kamalesh Babulal wrote:
>>  config SCSI_IBMVSCSI
>>         tristate "IBM Virtual SCSI support"
>> -       depends on PPC_PSERIES || PPC_ISERIES
>> +       depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH
>>         select SCSI_SRP_ATTRS
>>         help
>>           This is the IBM POWER Virtual SCSI Client
>
> As VIOPATH is iSeries code and is only used by the iSeries code, the 
> requirment should be
>
> depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
>
> except VIOPATH isn't selectable:
>
> arch/powerpc/platforms/iseries/Kconfig:
>
>  config VIOPATH
>         bool
>         depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
>         default y
>
> so instead we should be adding
>
> select VIOPATH if PPC_ISERIES
>
> to SCSI_IBMVSCSI and just
>
> select VIOPATH
>
> to HVC_ISERIES as it depends on PPC_ISERIES
>
> otherwise you have to enable one driver to get these other drivers.
>
> milton
>

Hi Milton,

	Thanks for the review comments, I am resending the patch with the 
changes you have recommended.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
 drivers/char/Kconfig |    1 +
 drivers/scsi/Kconfig |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Milton Miller - Jan. 5, 2009, 1:33 p.m.
On Jan 4, 2009, at 12:24 PM, Kamalesh Babulal wrote:

> Hi Milton,
>
> 	Thanks for the review comments, I am resending the patch with the
> changes you have recommended.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

Better, but you didn't include the change log, nor did you respond to 
Stephen's reply suggesting that all users be converted to select 
viopath (versus the proposed 2 select and 5 get it via depends and 
default y).

milton

Patch

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 1697043..b8da09a 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -616,6 +616,7 @@  config HVC_ISERIES
 	default y
 	select HVC_DRIVER
 	select HVC_IRQ
+	select VIOPATH
 	help
 	  iSeries machines support a hypervisor virtual console.
 
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index b732297..256c7be 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -884,6 +884,7 @@  config SCSI_IBMVSCSI
 	tristate "IBM Virtual SCSI support"
 	depends on PPC_PSERIES || PPC_ISERIES
 	select SCSI_SRP_ATTRS
+	select VIOPATH if PPC_ISERIES
 	help
 	  This is the IBM POWER Virtual SCSI Client