From patchwork Thu Jun 14 18:16:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v3,5/8] msix: Note endian TODO item Date: Thu, 14 Jun 2012 08:16:28 -0000 From: Alex Williamson X-Patchwork-Id: 164995 Message-Id: <20120614181627.23440.46436.stgit@bling.home> To: mst@redhat.com Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org MSIX, like PCI, is little endian. Specifying native is wrong here, but we need to check the rest of the file to determine if it's as simple as flipping this macro. Signed-off-by: Alex Williamson --- hw/msix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/msix.c b/hw/msix.c index 50885ac..87d316a 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr, static const MemoryRegionOps msix_mmio_ops = { .read = msix_mmio_read, .write = msix_mmio_write, + /* TODO: MSIX should be LITTLE_ENDIAN. */ .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4,