Patchwork [v3,5/8] msix: Note endian TODO item

login
register
mail settings
Submitter Alex Williamson
Date June 14, 2012, 6:16 p.m.
Message ID <20120614181627.23440.46436.stgit@bling.home>
Download mbox | patch
Permalink /patch/164995/
State New
Headers show

Comments

Alex Williamson - June 14, 2012, 6:16 p.m.
MSIX, like PCI, is little endian.  Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 hw/msix.c |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/hw/msix.c b/hw/msix.c
index 50885ac..87d316a 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@  static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
 static const MemoryRegionOps msix_mmio_ops = {
     .read = msix_mmio_read,
     .write = msix_mmio_write,
+    /* TODO: MSIX should be LITTLE_ENDIAN. */
     .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,