Patchwork [FWTS-TEST] checksum-0001: update to keep in sync with latest checksum test changes

login
register
mail settings
Submitter Colin King
Date June 14, 2012, 2:28 p.m.
Message ID <1339684132-27660-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/164942/
State Rejected
Headers show

Comments

Colin King - June 14, 2012, 2:28 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 checksum-0001/checksum-0004.log |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Ivan Hu - June 19, 2012, 5:35 a.m.
On 06/14/2012 10:28 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   checksum-0001/checksum-0004.log |    7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/checksum-0001/checksum-0004.log b/checksum-0001/checksum-0004.log
> index 8848c9d..1fe2a7b 100644
> --- a/checksum-0001/checksum-0004.log
> +++ b/checksum-0001/checksum-0004.log
> @@ -100,11 +100,12 @@ checksum        ADVICE: The kernel will warn that this table has an invalid chec
>   checksum        still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
>   checksum        messages.
>   checksum
> -checksum        FAILED [CRITICAL] ACPITableChecksum: Test 1, Table XSDT has incorrect checksum, expected 0xc2, got
> +checksum        FAILED [LOW] ACPITableChecksum: Test 1, Table XSDT has incorrect checksum, expected 0xc2, got
>   checksum        0xc3.
>   checksum
> -checksum        ADVICE: The kernel requires this table to have a valid checksum and will not load it. This will
> -checksum        lead to ACPI not working correctly.
> +checksum        ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
> +checksum        still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> +checksum        messages.
>   checksum
>   checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
>   checksum

Acked-by: Ivan Hu<ivan.hu@canonical.com>
Ivan Hu - June 19, 2012, 5:42 a.m.
On 06/19/2012 01:35 PM, IvanHu wrote:
> On 06/14/2012 10:28 PM, Colin King wrote:
>> From: Colin Ian King<colin.king@canonical.com>
>>
>> Signed-off-by: Colin Ian King<colin.king@canonical.com>
>> ---
>> checksum-0001/checksum-0004.log | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/checksum-0001/checksum-0004.log
>> b/checksum-0001/checksum-0004.log
>> index 8848c9d..1fe2a7b 100644
>> --- a/checksum-0001/checksum-0004.log
>> +++ b/checksum-0001/checksum-0004.log
>> @@ -100,11 +100,12 @@ checksum ADVICE: The kernel will warn that this
>> table has an invalid chec
>> checksum still load it. This is not a critical issue, but should be
>> fixed if possible to avoid the warning
>> checksum messages.
>> checksum
>> -checksum FAILED [CRITICAL] ACPITableChecksum: Test 1, Table XSDT has
>> incorrect checksum, expected 0xc2, got
>> +checksum FAILED [LOW] ACPITableChecksum: Test 1, Table XSDT has
>> incorrect checksum, expected 0xc2, got
>> checksum 0xc3.
>> checksum
>> -checksum ADVICE: The kernel requires this table to have a valid
>> checksum and will not load it. This will
>> -checksum lead to ACPI not working correctly.
>> +checksum ADVICE: The kernel will warn that this table has an invalid
>> checksum but will ignore the error and
>> +checksum still load it. This is not a critical issue, but should be
>> fixed if possible to avoid the warning
>> +checksum messages.
>> checksum
>> checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
>> checksum
>
> Acked-by: Ivan Hu<ivan.hu@canonical.com>
>
NACK: Ivan Hu<ivan.hu@canonical.com>
wait for update LOW -> MIDDLE checksum test case

Patch

diff --git a/checksum-0001/checksum-0004.log b/checksum-0001/checksum-0004.log
index 8848c9d..1fe2a7b 100644
--- a/checksum-0001/checksum-0004.log
+++ b/checksum-0001/checksum-0004.log
@@ -100,11 +100,12 @@  checksum        ADVICE: The kernel will warn that this table has an invalid chec
 checksum        still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
 checksum        messages.
 checksum        
-checksum        FAILED [CRITICAL] ACPITableChecksum: Test 1, Table XSDT has incorrect checksum, expected 0xc2, got
+checksum        FAILED [LOW] ACPITableChecksum: Test 1, Table XSDT has incorrect checksum, expected 0xc2, got
 checksum        0xc3.
 checksum        
-checksum        ADVICE: The kernel requires this table to have a valid checksum and will not load it. This will
-checksum        lead to ACPI not working correctly.
+checksum        ADVICE: The kernel will warn that this table has an invalid checksum but will ignore the error and
+checksum        still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
+checksum        messages.
 checksum        
 checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
 checksum