Patchwork rtc: twl: add missing IRQF_ONESHOT

login
register
mail settings
Submitter Felipe Balbi
Date June 14, 2012, 10:26 a.m.
Message ID <1339669606-9579-1-git-send-email-balbi@ti.com>
Download mbox | patch
Permalink /patch/164884/
State New
Headers show

Comments

Felipe Balbi - June 14, 2012, 10:26 a.m.
This patch gets rid of the following warning:

[    2.825378] genirq: Threaded irq requested with \
	handler=NULL and !ONESHOT for irq 363

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/rtc/rtc-twl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Santosh Shilimkar - June 14, 2012, 11:08 a.m.
On Thu, Jun 14, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> This patch gets rid of the following warning:
>
> [    2.825378] genirq: Threaded irq requested with \
>        handler=NULL and !ONESHOT for irq 363
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---

Ming Lei has posted a similar fix earlier [1]

Regards
Santosh
http://lkml.indiana.edu/hypermail/linux/kernel/1205.2/00668.html
Felipe Balbi - June 14, 2012, 11:08 a.m.
Hi,

On Thu, Jun 14, 2012 at 04:38:34PM +0530, Shilimkar, Santosh wrote:
> On Thu, Jun 14, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> > This patch gets rid of the following warning:
> >
> > [    2.825378] genirq: Threaded irq requested with \
> >        handler=NULL and !ONESHOT for irq 363
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> 
> Ming Lei has posted a similar fix earlier [1]

good, never mind this one then

Patch

diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index 258abea..c5d06fe 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -510,7 +510,7 @@  static int __devinit twl_rtc_probe(struct platform_device *pdev)
 	}
 
 	ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
-				   IRQF_TRIGGER_RISING,
+				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 				   dev_name(&rtc->dev), rtc);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "IRQ is not free.\n");