From patchwork Wed Jun 13 17:58:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 164734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 62F52B6FAC for ; Thu, 14 Jun 2012 03:58:43 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340215123; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Mail-Followup-To:Cc:Subject:References:Date: In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=ZpjzTyVbuaNAByXJRmuA iH8LcpY=; b=R+bvEyCOUjyk5iM7D4AOFDTdIG9gRn0mO2byDM8Z2NlrdWjwvhun QjAFBnJcEmZ/ZkQa+X4YtMJSrGXRa/QOtT950wZ7pIO6eb30WSOurgzs86HMnBWp I5osvxlqFhWjLBFSEVjHyw/6Icuwa77X9Tg+JKsQDGwXxSIqooeuCVU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Mail-Followup-To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=vVg6sEGGVcEwGfSnIntt5FD4GOwhRCD5+7EYNDbbRkDX5LffPTZngWIaXo1pjI /H4An5wP5H6fG/309gzCaFXHwPGTF37S/WmnzWchqCkZ9Vwnwifj73dVeZiNB+Zk /DWQM6Pi5To+QO3FjMGscfUb40gSkNmvTAy41inogm7aw=; Received: (qmail 26891 invoked by alias); 13 Jun 2012 17:58:39 -0000 Received: (qmail 26880 invoked by uid 22791); 13 Jun 2012 17:58:38 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ee0-f47.google.com (HELO mail-ee0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 17:58:21 +0000 Received: by eekd49 with SMTP id d49so315434eek.20 for ; Wed, 13 Jun 2012 10:58:20 -0700 (PDT) Received: by 10.14.45.10 with SMTP id o10mr486292eeb.166.1339610299960; Wed, 13 Jun 2012 10:58:19 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk. [82.133.89.107]) by mx.google.com with ESMTPS id p41sm10190413eef.5.2012.06.13.10.58.17 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Jun 2012 10:58:18 -0700 (PDT) From: Richard Sandiford To: Steve Ellcey Mail-Followup-To: Steve Ellcey , David Daney , , rdsandiford@googlemail.com Cc: David Daney , Subject: Re: MIPS testsuite patch for --with-synci configurations References: <4FD69A34.90502@cavium.com> <1339513266.21213.447.camel@ubuntu-sellcey> Date: Wed, 13 Jun 2012 18:58:18 +0100 In-Reply-To: <1339513266.21213.447.camel@ubuntu-sellcey> (Steve Ellcey's message of "Tue, 12 Jun 2012 08:01:04 -0700") Message-ID: <874nqfccw5.fsf@talisman.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Steve Ellcey writes: > On Mon, 2012-06-11 at 18:24 -0700, David Daney wrote: > >> > This patch addes the -mno-synci flag to MIPS tests that specify an >> > architecture that does not support synci, thus getting rid of the >> > warning message and making the tests pass. Tested with the mips-linux-gnu >> > and mips-sde-elf targets both with and without --with-synci on the >> > GCC configuration. >> > >> > OK to checkin? >> >> I wonder if it would make more sense to modify the testsuite driver to >> take care of this. It seems like the set of files with the -mno-synci >> annotation could easily become different than the set that requires it. >> >> David Daney > > I did think about that, but the number of flags that I would have to > check for in the testsuite driver to decide whether or not to turn on > -mno-synci was large enough to make me not want to do it that way. > > I would need to check the isa= and isa_rev= flags that are currently > handled in the driver, the -mabi flag, the -march flag, and the -mips > flag. The number of values that each flag could have (particularly > -march) is rather large. I can imagine people adding a new test and > forgetting to add -mno-synci but that would be easy to fix and no worse > then adding a new -march value and not handling it in the test suite > driver. I agree with David. This is really the same kind of situation as we already have for -m(no-)dsp, etc. There too we need to override an explicit -mdsp (which might be added using --target_board, etc.) when testing a target that doesn't support the DSP ASE. I think the patch below should be enough. Spot-checked on mips64-elf using --target_board mips-sim-idt64/-mips64r2/-msynci. Could you give it a go with your target? Thanks, Richard gcc/testsuite/ * gcc.target/mips/mips.exp (mips-dg-options): Handle -msynci. Index: gcc/testsuite/gcc.target/mips/mips.exp =================================================================== --- gcc/testsuite/gcc.target/mips/mips.exp 2012-02-07 19:23:25.000000000 +0000 +++ gcc/testsuite/gcc.target/mips/mips.exp 2012-06-13 18:54:03.507449114 +0100 @@ -839,6 +839,8 @@ proc mips-dg-finish {} { # | | # -mdsp -mno-dsp # | | +# -msynci -mno-synci +# | | # +-- gp, abi & arch ---------+ # # For these purposes, the "gp", "abi" & "arch" option groups are treated @@ -987,6 +989,7 @@ proc mips-dg-options { args } { # - the DSP ASE if { $isa_rev < 2 && (($gp_size == 32 && [mips_have_test_option_p options "-mfp64"]) + || [mips_have_test_option_p options "-msynci"] || [mips_have_test_option_p options "-mdsp"] || [mips_have_test_option_p options "-mdspr2"]) } { if { $gp_size == 32 } { @@ -1150,6 +1153,7 @@ proc mips-dg-options { args } { mips_make_test_option options "-mfp32" } mips_make_test_option options "-mno-dsp" + mips_make_test_option options "-mno-synci" } unset arch unset isa