Message ID | 874nqfccw5.fsf@talisman.home |
---|---|
State | New |
Headers | show |
On Wed, 2012-06-13 at 18:58 +0100, Richard Sandiford wrote: > I agree with David. This is really the same kind of situation as we > already have for -m(no-)dsp, etc. There too we need to override an > explicit -mdsp (which might be added using --target_board, etc.) > when testing a target that doesn't support the DSP ASE. > > I think the patch below should be enough. Spot-checked on mips64-elf > using --target_board mips-sim-idt64/-mips64r2/-msynci. Could you > give it a go with your target? > > Thanks, > Richard Excellent, this patch works great and fixed all the unexpected failures I was getting due to --with-synci. I guess I need to study mips.exp a bit more to understand all of what it can do. Steve Ellcey sellcey@mips.com
Index: gcc/testsuite/gcc.target/mips/mips.exp =================================================================== --- gcc/testsuite/gcc.target/mips/mips.exp 2012-02-07 19:23:25.000000000 +0000 +++ gcc/testsuite/gcc.target/mips/mips.exp 2012-06-13 18:54:03.507449114 +0100 @@ -839,6 +839,8 @@ proc mips-dg-finish {} { # | | # -mdsp -mno-dsp # | | +# -msynci -mno-synci +# | | # +-- gp, abi & arch ---------+ # # For these purposes, the "gp", "abi" & "arch" option groups are treated @@ -987,6 +989,7 @@ proc mips-dg-options { args } { # - the DSP ASE if { $isa_rev < 2 && (($gp_size == 32 && [mips_have_test_option_p options "-mfp64"]) + || [mips_have_test_option_p options "-msynci"] || [mips_have_test_option_p options "-mdsp"] || [mips_have_test_option_p options "-mdspr2"]) } { if { $gp_size == 32 } { @@ -1150,6 +1153,7 @@ proc mips-dg-options { args } { mips_make_test_option options "-mfp32" } mips_make_test_option options "-mno-dsp" + mips_make_test_option options "-mno-synci" } unset arch unset isa